Reduce WAN check timeout #6290
Merged
Reduce WAN check timeout #6290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmahmood
approved these changes
Sep 12, 2017
chengwang86
reviewed
Sep 12, 2017
| @@ -186,7 +187,7 @@ func NewValidator(ctx context.Context, vch *config.VirtualContainerHostConfigSpe | |||
| nwErrors := []error{} | |||
|
|
|||
| // create a http client with a custom transport using the proxy from env vars | |||
| client := &http.Client{Timeout: 30 * time.Second} | |||
| client := &http.Client{Timeout: 10 * time.Second} | |||
There was a problem hiding this comment.
So 10 sec or 5 sec? I thought you wanted to reduce the timeout to 5 sec
There was a problem hiding this comment.
Talked with @hmahmood and settled on 10, @chengwang86
There was a problem hiding this comment.
Sorry, didn't update the original description after the first commit ;P
chengwang86
approved these changes
Sep 12, 2017
mhagen-vmware
pushed a commit
that referenced
this pull request
Sep 13, 2017
mhagen-vmware
added a commit
that referenced
this pull request
Sep 13, 2017
AngieCris
pushed a commit
to AngieCris/vic
that referenced
this pull request
Nov 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce the WAN check in vicadmin timeout to 5 seconds so that the page will load quickly regardless of whether or not the VCH has extranet access.