[specific ci=1-25-Docker-Port-Map]unmap port only for mapped container #6210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgtexmex
approved these changes
Sep 5, 2017
hmahmood
approved these changes
Sep 6, 2017
vburenin
approved these changes
Sep 6, 2017
mhagen-vmware
pushed a commit
that referenced
this pull request
Sep 13, 2017
#6210) * fix wrong port umapping * add test case
mhagen-vmware
added a commit
that referenced
this pull request
Sep 13, 2017
AngieCris
pushed a commit
to AngieCris/vic
that referenced
this pull request
Nov 20, 2017
vmware#6210) * fix wrong port umapping * add test case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6197
During container remove, or in container event handler in persona, it will try to unmap port mapping if the configured port is mapped. But the unmapping didn't check if the stopped or removed container is the mapped container in port mapping.
The result is that if two containers have same port mapping, with only one container is running, if remove the stopped container, the port mapping for running container will be removed, and make the connection unreachable, even if nothing happens for the running container.