Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker exec should use working directory of container image by default #8166

Open
hickeng opened this issue Jul 31, 2018 · 2 comments
Open
Labels
area/containerd area/docker Support for the Docker operations component/persona/docker component/portlayer/execution component/tether severity/4-minor Low usability or functional impact. Often has an easy workaround. source/customer Reported by a customer, directly or via an intermediary team/container

Comments

@hickeng
Copy link
Member

hickeng commented Jul 31, 2018

Story
As a user of VCH containers I expect consistent behaviour with regular docker.

Detail
docker exec was updated to use the container image working directory as part of the shift to containerd (see moby/moby@ddae20c#diff-3ed197c0a6f7a9ca73a3ee424e448ac1R222).

We should adopt this behaviour for consistency with base docker, but should do so at the same time as adding support for the exec -w option to explicitly set the working directory so that there is an easy path for restoring old behaviour.

This is not target at a patch release as it's a breaking behaviour.

Workaround
It's not a great workaround, but it's the same approach as was needed before docker changed the behaviour:

sh -c "cd /desired/dir && command-to-run"
@hickeng hickeng added area/docker Support for the Docker operations component/persona/docker component/portlayer/execution component/tether impact/doc/note Requires creation of or changes to an official release note source/customer Reported by a customer, directly or via an intermediary area/containerd team/container severity/4-minor Low usability or functional impact. Often has an easy workaround. labels Jul 31, 2018
@stuclem
Copy link
Contributor

stuclem commented Sep 17, 2018

Added the following to the release notes:

  • docker exec should use working directory of container image by default . #8166
    docker exec was updated to use the container image working directory as part of the shift to containerd. vSphere Integrated Containers does not yet implement the exec -w option, so does not behave consistently with Docker.

    Workaround: Use the same approach as was necessary before Docker changed the behavior:

    sh -c "cd /desired/dir && command-to-run

@hickeng does this cover it?

@stuclem
Copy link
Contributor

stuclem commented Jan 16, 2019

Already in the RNs. Removing note tag.

@stuclem stuclem removed the impact/doc/note Requires creation of or changes to an official release note label Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/containerd area/docker Support for the Docker operations component/persona/docker component/portlayer/execution component/tether severity/4-minor Low usability or functional impact. Often has an easy workaround. source/customer Reported by a customer, directly or via an intermediary team/container
Projects
None yet
Development

No branches or pull requests

2 participants