Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add implementation for vapp network NAT rules resource #517

Merged
merged 34 commits into from
Jun 23, 2020
Merged

Add implementation for vapp network NAT rules resource #517

merged 34 commits into from
Jun 23, 2020

Conversation

vbauzys
Copy link
Contributor

@vbauzys vbauzys commented Jun 9, 2020 •
edited
Loading

Dep: vmware/go-vcloud-director#316
Ref: #329

New resource to manage vapp network NAT rules

This PR is derived from #511 so shows that PR code too.

@vbauzys vbauzys requested a review from Didainius June 9, 2020 09:59
@vbauzys vbauzys self-assigned this Jun 9, 2020
@vbauzys vbauzys requested review from lvirbalas and dataclouder June 9, 2020 09:59
@vbauzys vbauzys marked this pull request as ready for review June 9, 2020 10:00
vbauzys added 10 commits June 15, 2020 11:52
@vbauzys
Merge branch 'master' into vapp-nat
23c57ba 
# Conflicts:
#	vcd/provider.go
@vbauzys
Merge branch 'master' into vapp-nat
ab4f469 
# Conflicts:
#	vcd/provider.go
@vbauzys
bump govcd
f3fc3d2
@vbauzys
Merge branch 'master' into vapp-nat
e6a0f57 
# Conflicts:
#	go.sum
#	vcd/provider.go
#	vendor/github.com/vmware/go-vcloud-director/v2/govcd/vapp_network.go
#	vendor/github.com/vmware/go-vcloud-director/v2/types/v56/types.go
#	vendor/modules.txt
@vbauzys
fix after merge
df5c070
@vbauzys
add main implementation
8ac788f
@vbauzys
Merge branch 'vapp-fw' into vapp-nat
549a515 
# Conflicts:
#	go.mod
#	go.sum
#	vcd/provider.go
#	vendor/github.com/vmware/go-vcloud-director/v2/types/v56/types.go
#	vendor/modules.txt
@vbauzys
bump govcd
66a094b
@vbauzys
bump govcd and fix error
a20c245
@vbauzys
bump govcd and fix error
2d878f9
@vbauzys vbauzys mentioned this pull request Jun 18, 2020
Merged
vbauzys added 4 commits June 19, 2020 13:13
@vbauzys
Merge branch 'master' into vapp-nat
1efd6d1 
# Conflicts:
#	go.mod
#	vendor/modules.txt
@vbauzys
Merge branch 'master' into vapp-nat
46d513f 
# Conflicts:
#	go.mod
#	vendor/modules.txt
@vbauzys
Removing not needed commit
6c751bb 
This reverts commit 8ac788f
@vbauzys
Improvements
202f6be
Didainius
Didainius reviewed Jun 22, 2020
View reviewed changes
Copy link
Collaborator

@Didainius Didainius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still have to play with it, but leaving initial review comments.

vcd/resource_vcd_vapp_firewall_rules.go Outdated Show resolved Hide resolved
vcd/resource_vcd_vapp_firewall_rules.go Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
vcd/resource_vcd_vapp_nat_rules.go Outdated Show resolved Hide resolved
vcd/resource_vcd_vapp_nat_rules.go Outdated Show resolved Hide resolved
vcd/resource_vcd_vapp_nat_rules_test.go Show resolved Hide resolved
website/docs/r/vapp_nat_rules.html.markdown Outdated Show resolved Hide resolved
website/docs/r/vapp_nat_rules.html.markdown Outdated Show resolved Hide resolved
vcd/resource_vcd_vapp_nat_rules.go Show resolved Hide resolved
website/docs/r/vapp_nat_rules.html.markdown Outdated Show resolved Hide resolved
dataclouder
dataclouder suggested changes Jun 23, 2020
View reviewed changes
Copy link
Contributor

@dataclouder dataclouder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes required

vcd/resource_vcd_vapp_nat_rules.go Outdated Show resolved Hide resolved
vcd/resource_vcd_vapp_nat_rules.go Outdated Show resolved Hide resolved
vcd/resource_vcd_vapp_nat_rules.go Outdated Show resolved Hide resolved
Didainius
Didainius reviewed Jun 23, 2020
View reviewed changes
vcd/resource_vcd_vapp_nat_rules_test.go Show resolved Hide resolved
vcd/resource_vcd_vapp_nat_rules_test.go Show resolved Hide resolved
website/docs/r/vapp_nat_rules.html.markdown Outdated Show resolved Hide resolved
website/docs/r/vapp_nat_rules.html.markdown Outdated Show resolved Hide resolved
website/docs/r/vapp_nat_rules.html.markdown Show resolved Hide resolved
lvirbalas
lvirbalas requested changes Jun 23, 2020
View reviewed changes
vcd/resource_vcd_vapp_nat_rules.go Outdated Show resolved Hide resolved
lvirbalas
lvirbalas reviewed Jun 23, 2020
View reviewed changes
vcd/resource_vcd_vapp_firewall_rules.go Outdated Show resolved Hide resolved
vcd/resource_vcd_vapp_firewall_rules.go Show resolved Hide resolved
vcd/resource_vcd_vapp_firewall_rules.go Outdated Show resolved Hide resolved
lvirbalas
lvirbalas approved these changes Jun 23, 2020
View reviewed changes
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now! Thanks!

vbauzys added 2 commits June 23, 2020 17:08
@vbauzys
bump govcd
ba43c55
@vbauzys
Merge branch 'master' into vapp-nat
114eb25 
# Conflicts:
#	CHANGELOG.md
#	go.sum
#	vcd/provider.go
#	vendor/modules.txt
dataclouder
dataclouder approved these changes Jun 23, 2020
View reviewed changes
Copy link
Contributor

@dataclouder dataclouder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vbauzys vbauzys merged commit 7440130 into vmware:master Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Didainius Didainius Didainius approved these changes

@lvirbalas lvirbalas lvirbalas approved these changes

@dataclouder dataclouder dataclouder approved these changes

Assignees

@vbauzys vbauzys

Labels
dependencies documentation size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vbauzys @lvirbalas @dataclouder @Didainius