Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python 3.x compatibility #55

Closed
embodyhumility opened this issue Jun 13, 2014 · 11 comments · Fixed by #89
Closed

python 3.x compatibility #55

embodyhumility opened this issue Jun 13, 2014 · 11 comments · Fixed by #89
Assignees
@hartsock
Labels
blocker high priority VMware Staff Assist Needed
Milestone
pyVmomi 5.5.0-2014.1

Comments

@embodyhumility
Copy link

Is anyone using python 3 with this successfully?
@michaelrice
Copy link
Contributor

@embodyhumility I dont think so. I am not super familiar with python 3 but it seems like there were some changes with how you do imports that would keep this from being compatible. I have a branch where I have tried building and testing on python 3 with travis-ci and it fails.

See: https://travis-ci.org/michaelrice/pyvmomi/builds/27107734

@michaelrice michaelrice mentioned this issue Jun 18, 2014
Closed
@hartsock hartsock added this to the pyVmomi 5.5.0-2014.1 milestone Jun 18, 2014
@hartsock hartsock self-assigned this Jun 18, 2014
@hartsock hartsock changed the title Does this API work with python 3.x? python 3.x compatibility Jun 18, 2014
@hartsock hartsock mentioned this issue Jun 19, 2014
Merged
@hartsock
Copy link
Member

We'll need to manage not only a few light syntax changes but also a few library changes. I will want to find some way to regression test the whole lib before we merge this to the master so I've created a python3 branch to do ONLY python3 compatibility work. Right after we merge that I'll want to rebase and merge the pep8 support work.

BTW: I'm taking this task myself.

@hartsock hartsock mentioned this issue Jun 26, 2014
Closed
@hartsock
Copy link
Member

So far this change has forced me to pull in a number of other patch streams. There's also a huge issue with the dynamic class generators in python 3. This may spiral out into a very big job.

hartsock pushed a commit to hartsock/pyvmomi that referenced this issue Jun 26, 2014
@higebu @hartsock
Fixes for Python 3 with 2to3
85dec72 
partial vmware#55
hartsock added a commit to hartsock/pyvmomi that referenced this issue Jun 26, 2014
@hartsock
update samples for python3
f7dd0d0 
Small changes related to python 3 compatability.

partial vmware#55
hartsock added a commit to hartsock/pyvmomi that referenced this issue Jun 26, 2014
@hartsock
python3 support: bare vim and vmodl packages
b49b442 
A common problem with using pyVmomi is that the
packages pyVmomi.vim and pyVmomi.vmodl do not
actually exist.

In python3 we aren't allowed to have faux packages anymore.

partial: vmware#55
hartsock added a commit to hartsock/pyvmomi that referenced this issue Jun 26, 2014
@hartsock
python3 support for connect
b2161c8 
more advanced module changes to support python3 including
library migration.

partial  vmware#55
hartsock pushed a commit to hartsock/pyvmomi that referenced this issue Jun 26, 2014
@higebu @hartsock
Fixes for Python 3 with 2to3
57f48ea 
partial vmware#55
hartsock added a commit to hartsock/pyvmomi that referenced this issue Jul 28, 2014
@hartsock
python3: absolute import
8ee385a 
Use absolute import from the __future__ module to prepare
the library for use in python 3

partial: vmware#55
hartsock added a commit to hartsock/pyvmomi that referenced this issue Jul 28, 2014
@hartsock
python3: Iso8601 print_function
a8c1be6 
Moves Iso8601 to using the print_function.
NOTE(should not use print at all here)

partial: vmware#55
hartsock pushed a commit to hartsock/pyvmomi that referenced this issue Jul 28, 2014
@higebu @hartsock
python3: 2to3 tool
170ea1d 
Fixes for Python 3 with 2to3

partial vmware#55
hartsock added a commit to hartsock/pyvmomi that referenced this issue Jul 28, 2014
@hartsock
python3: more 2 to 3 tool fixes
1febb9a 
Changes exception statements to match python 3 style

partial: vmware#55
hartsock added a commit to hartsock/pyvmomi that referenced this issue Jul 28, 2014
@hartsock
python3: unicode - minimalist change set
0555204 
A minimal change set to deal with unicode modules and methods between
python2 and python3. A deeper reworking of the unicode components
is very likely called for, however, this change should get the library
working on python3.

partial: vmware#55
hartsock pushed a commit to hartsock/pyvmomi that referenced this issue Jul 28, 2014
@hartsock
python3: string formatting
95c9a70 
remove all old style string formatting from Soapadapter.py and move to
.format() syntax for python 3 compatibility

partial vmware#55
hartsock added a commit to hartsock/pyvmomi that referenced this issue Jul 28, 2014
@hartsock
python3: travis environment tweaks
bbff92d 
Travis CI configuration tweaks for python3 support

partial: vmware#55
hartsock added a commit to hartsock/pyvmomi that referenced this issue Jul 28, 2014
@hartsock
python3: unittest define main
e88f67a 
Code change to unit tests for python3.

partial: vmware#55
hartsock added a commit to hartsock/pyvmomi that referenced this issue Jul 28, 2014
@hartsock
python3: version neutral API
ad73d76 
Using the six library we make version neutral API calls to
dictionary methods and to unicode methods.

partial: vmware#55
hartsock added a commit to hartsock/pyvmomi that referenced this issue Jul 28, 2014
@hartsock
python3: version neutral API
de17170 
Using the six library we make version neutral API calls to
dictionary methods and to unicode methods.

partial: vmware#55
hartsock pushed a commit to hartsock/pyvmomi that referenced this issue Jul 28, 2014
@kevin1024 @hartsock
python3: replace thread module with threading
a96438c 
partial: vmware#55
hartsock pushed a commit to hartsock/pyvmomi that referenced this issue Jul 28, 2014
@kevin1024 @hartsock
python3: change call to urlparse
f93ddf9 
partial: vmware#55
hartsock pushed a commit to hartsock/pyvmomi that referenced this issue Jul 28, 2014
@kevin1024 @hartsock
python3: fix some syntax errors
2e1b8de 
partial: vmware#55
hartsock pushed a commit to hartsock/pyvmomi that referenced this issue Jul 28, 2014
@kevin1024 @hartsock
python3: fix some syntax errors
66e515b 
partial: vmware#55
@hartsock hartsock mentioned this issue Jul 28, 2014
Merged
@hartsock
Copy link
Member

Special thanks to @kevin1024 for a few pointers on python 3 support.

@hartsock hartsock mentioned this issue Jul 28, 2014
Merged
@hartsock
Copy link
Member

Changes merged. The master currently supports python 3. We will cut a new release as soon as the other open issues are closed.

hartsock pushed a commit to hartsock/pyvmomi that referenced this issue Jul 29, 2014
@higebu @hartsock
python3: 2to3 tool
62c8e45 
Fixes for Python 3 with 2to3

partial vmware#55
hartsock added a commit to hartsock/pyvmomi that referenced this issue Jul 29, 2014
@hartsock
python3: more 2 to 3 tool fixes
4c68638 
Changes exception statements to match python 3 style

partial: vmware#55
hartsock added a commit to hartsock/pyvmomi that referenced this issue Jul 29, 2014
@hartsock
python3: unicode - minimalist change set
1e4c9f3 
A minimal change set to deal with unicode modules and methods between
python2 and python3. A deeper reworking of the unicode components
is very likely called for, however, this change should get the library
working on python3.

partial: vmware#55
hartsock pushed a commit to hartsock/pyvmomi that referenced this issue Jul 29, 2014
@hartsock
python3: string formatting
2cdf07f 
remove all old style string formatting from Soapadapter.py and move to
.format() syntax for python 3 compatibility

partial vmware#55
hartsock added a commit to hartsock/pyvmomi that referenced this issue Jul 29, 2014
@hartsock
python3: travis environment tweaks
f9e57fd 
Travis CI configuration tweaks for python3 support

partial: vmware#55
hartsock added a commit to hartsock/pyvmomi that referenced this issue Jul 29, 2014
@hartsock
python3: unittest define main
b6dd99e 
Code change to unit tests for python3.

partial: vmware#55
hartsock added a commit to hartsock/pyvmomi that referenced this issue Jul 29, 2014
@hartsock
python3: KeyError uses '%' not format method
6f36a6a 
* Malformed Faults: introduces test for fault handler
* fixes KeyError raises statements to use 'format' instead

partial: vmware#72
partial: vmware#55
hartsock added a commit to hartsock/pyvmomi that referenced this issue Jul 30, 2014
@hartsock
python3: KeyError uses '%' not format method
dac8a79 
* Malformed Faults: introduces test for fault handler
* fixes KeyError raises statements to use 'format' instead

partial: vmware#72
partial: vmware#55
hartsock added a commit to hartsock/pyvmomi that referenced this issue Jul 30, 2014
@hartsock
python3: KeyError to use format
c84a6a9 
Changes KeyError signatures to use `format` instead of `%`

partial: vmware#55
@hartsock hartsock mentioned this issue Jul 30, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hartsock hartsock

Labels
blocker high priority VMware Staff Assist Needed
Projects
None yet
Milestone
pyVmomi 5.5.0-2014.1
Development

Successfully merging a pull request may close this issue.

Python3 vmware/pyvmomi
3 participants
@hartsock @michaelrice @embodyhumility