Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vcsim: Fix RefreshDatastore to return a valid response #3199

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

dekp
Copy link
Contributor

@dekp dekp commented Aug 3, 2023

Description

Fixed the implementation of RefreshDatastore in the VC simulator to set the response field when there is no fault (i.e. happy path) in order to avoid serialization problems.

Closes: #3198

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update
  • Build related change

How Has This Been Tested?

  • Modified the existing unit test for RefreshDatastore to validate the response field.
  • Developer testing via standalone govmomi-based client against vcsim.

Checklist:

  • My code follows the CONTRIBUTION guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

@dekp dekp requested review from dougm and karaatanassov August 3, 2023 12:28
@dekp dekp self-assigned this Aug 3, 2023
Copy link
Member

@dougm dougm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dekp

@dougm dougm merged commit ba843e5 into vmware:main Aug 3, 2023
@dekp dekp deleted the issue-3198 branch August 4, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] vcsim: RefreshDatastore should return a valid response
3 participants