Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Dockerfile & steps for generating types #3185

Merged
merged 1 commit into from
Jul 21, 2023
Merged

chore: Dockerfile & steps for generating types #3185

merged 1 commit into from
Jul 21, 2023

Conversation

akutz
Copy link
Member

@akutz akutz commented Jul 21, 2023 •
edited
Loading

Description

This patch:

  • Introduces a cross-arch ./gen/Dockerfile for generating the vim types.
  • Documents the process at ./gen/README.md.
  • Introduces a Makefile target generate-types for generating the vim types.
  • Enables ./gen/gen.sh to automatically update the VIM version in vim25/client.go.
  • Ensures ./gen/rbvmomi/vmodl.db is downloaded if it does not already exist when generating types.

Closes: NA

Type of change

Please mark options that are relevant:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update
  • Build related change

How Has This Been Tested?

make generate-types

Checklist:

  • My code follows the CONTRIBUTION
    guidelines of
    this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

@akutz akutz force-pushed the feature/dockerfile-for-generating-types branch from 9a5f659 to 81d96f5 Compare July 21, 2023 19:35
@akutz
chore: Dockerfile & steps for generating types
c460f70 
This patch introduces a Dockerfile for generating the
vim types. The image should be cross-arch compatible.

This patch also enables "gen.sh" to automatically update
the VIM version in "vim25/client.go".

This patch also ensures "gen/rbvmomi/vmodl.db" is downloaded
if it does not already exist when generating types.
@akutz akutz force-pushed the feature/dockerfile-for-generating-types branch from 81d96f5 to c460f70 Compare July 21, 2023 19:54
dougm
dougm approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@dougm dougm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks @akutz !

@akutz
Copy link
Member Author

akutz commented Jul 21, 2023

Many thanks to @mayankbh for validating this on an x86 host as well!

@akutz akutz merged commit cd0cb63 into vmware:main Jul 21, 2023
@akutz akutz deleted the feature/dockerfile-for-generating-types branch July 21, 2023 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougm dougm dougm approved these changes

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akutz @dougm @vmwclabot