Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container backed hosts in simulator #3177

Merged
merged 8 commits into from
Aug 8, 2023
Merged

Container backed hosts in simulator #3177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
fdb4d84
vcsim: untangle container/VM to allow reuse of container logic for hosts
hickeng Apr 19, 2023
387dc6e
vcsim: support container backing for hosts
hickeng Apr 22, 2023
6b7b0df
vcsim: per-host OptionManager instances and differentiated roles
hickeng Apr 26, 2023
6248cbf
vcsim: create underlay network for pNICs in container-backed hosts
hickeng Jul 7, 2023
6f34f13
vcsim: container backing respects changes via reconfigure
hickeng Jul 14, 2023
9b2ef98
vcsim: use docker event for efficient monitoring
hickeng Aug 2, 2023
2b5c457
vcsim: add interactive debug github action stage
hickeng Jul 14, 2023
f636e96
Address review comments
hickeng Aug 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/govmomi-go-tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,3 +60,6 @@ jobs:
TEST_TIMEOUT: 5m
TEST_OPTS: ""
run: make go-test
- name: Debug with tmate on failure
if: ${{ failure() }}
uses: mxschmitt/action-tmate@v3
4 changes: 4 additions & 0 deletions .github/workflows/govmomi-govc-tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,10 @@ jobs:
run: |
make ${{ matrix.cmd }}

- name: Debug with tmate on failure
if: ${{ failure() }}
uses: mxschmitt/action-tmate@v3

govc-docs:
name: Verify govc docs are up2date
strategy:
Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ endif

.PHONY: go-test
go-test: ## Runs go unit tests with race detector enabled
GORACE=$(GORACE) $(GO) test \
GORACE=$(GORACE) CGO_ENABLED=1 $(GO) test \
-count $(TEST_COUNT) \
-race \
-timeout $(TEST_TIMEOUT) \
Expand Down
2 changes: 1 addition & 1 deletion govc/test/vcsim.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,7 @@ EOF
run docker inspect -f '{{.State.Status}}' "$name"
assert_success "running"

run docker volume inspect "$name"
run docker volume inspect "$name--dmi"
assert_success

run govc vm.destroy $vm
Expand Down
2 changes: 1 addition & 1 deletion simulator/cluster_compute_resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ func (add *addHost) Run(task *Task) (types.AnyType, types.BaseMethodFault) {
}

host := NewHostSystem(template)
host.configure(spec, add.req.AsConnected)
host.configure(task.ctx, spec, add.req.AsConnected)

task.ctx.Map.PutEntity(cr, task.ctx.Map.NewEntity(host))
host.Summary.Host = &host.Self
Expand Down
Loading