Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Property Collector Updates should be triggered on the empty FilterSet #3631

Closed
brakthehack opened this issue Nov 21, 2024 · 0 comments · Fixed by #3632
Closed

[BUG] Property Collector Updates should be triggered on the empty FilterSet #3631

brakthehack opened this issue Nov 21, 2024 · 0 comments · Fixed by #3632

Comments

@brakthehack
Copy link
Contributor

brakthehack commented Nov 21, 2024 •
edited
Loading

Describe the bug
The PropertyCollector update closure passed to WaitForUpdatesEx is only triggered when a non-empty FilterSet occurs. This is an issue when side effects need to be triggered inside the update function such as notification mechanisms that an update was acknowledged.

It should be the choice of the update closure to determine whether to process the empty FilterSet or not.

To Reproduce
Steps to reproduce the behavior:

  1. Create a container view with no child entities such as an empty vm or host folder.
  2. Call wait for updates on the view.
  3. Observe that the update closure passed to WFU was not triggered even when an iteration of the WFU loop was processed.

Expected behavior
The onUpdatesFn should be triggered even if the FilterSet is empty.

Affected version
Since 95aa257.

Screenshots/Debug Output
N/A

Additional context
N/A
@brakthehack brakthehack changed the title [BUG] Property Collector Updates should be triggered on the empty UpdateSet [BUG] Property Collector Updates should be triggered on the empty FilterSet Nov 21, 2024
brakthehack pushed a commit to brakthehack/govmomi that referenced this issue Nov 21, 2024
Property Collector updates should be triggered on the empty FilterSet
117d904 
The PropertyCollector update closure passed to WaitForUpdatesEx is only
triggered when a non-empty FilterSet occurs.
This is an issue when side effects need to be triggered inside the
update function such as notification mechanisms that an update was
acknowledged.

It should be the choice of the update closure to determine whether to
process the empty FilterSet or not.

Closes vmware#3631
@brakthehack brakthehack mentioned this issue Nov 21, 2024
Merged
brakthehack pushed a commit to brakthehack/govmomi that referenced this issue Nov 21, 2024
Property Collector updates should be triggered on the empty FilterSet
487c6f0 
The PropertyCollector update closure passed to WaitForUpdatesEx is only
triggered when a non-empty FilterSet occurs.
This is an issue when side effects need to be triggered inside the
update function such as notification mechanisms that an update was
acknowledged.

It should be the choice of the update closure to determine whether to
process the empty FilterSet or not.

Closes vmware#3631
dougm pushed a commit that referenced this issue Dec 5, 2024
@dougm
fix: Property Collector updates should be triggered on the empty Filt…
3f5f887 
…erSet

The PropertyCollector update closure passed to WaitForUpdatesEx is only
triggered when a non-empty FilterSet occurs.
This is an issue when side effects need to be triggered inside the
update function such as notification mechanisms that an update was
acknowledged.

It should be the choice of the update closure to determine whether to
process the empty FilterSet or not.

Closes #3631

Signed-off-by: Brian Rak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Property Collector updates should be triggered on the empty FilterSet brakthehack/govmomi
1 participant
@brakthehack