Add vm.Shutdown() function and tests #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shutdown triggers a VM undeploy and shutdown action. "Shut Down Guest OS" action in UI behaves this way.
Co-authored-by: lvirbalas <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Closed
adambarreiro
approved these changes
Aug 22, 2022
Signed-off-by: Dainius Serplis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR works on top of good work done in #413 by @lelvisl and adds a test
Test_VmShutdownwhich tracks status of Guest customization and triggers shutdown. The shutdown only works when guest tools are running.A few additional things occured to comply with Go 1.19: * Additionally it does `make fmt` using Go 1.19 as it has a few doc comment changes. * Staticcheck complained about `package io/ioutil is deprecated`. In reality some of functions were moved to `io`, others to `os`, so only import paths changed.All above was done in separate PR #497
Closes #413