Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix edge gateway list retrieval #364

Merged
merged 6 commits into from
Mar 23, 2021
Merged

Fix edge gateway list retrieval #364

merged 6 commits into from
Mar 23, 2021

Conversation

dataclouder
Copy link
Contributor

Fix Issue #363
Edge gateway retrieval was cut at the first 25 items.

Giuseppe Maxia added 3 commits March 23, 2021 10:23
Fix wording in CONTRIBUTING.md
9c6f95f 
Signed-off-by: Giuseppe Maxia <[email protected]>
Add method vdc.QueryEdgeGatewayList
4b302be 
Deprecate method vdc.GetEdgeGatewayRecordsType

Signed-off-by: Giuseppe Maxia <[email protected]>
Remove usage of vcd.GetEdgeGatewayRecordsType
6d39686 
replaced with vdc.QueryEdgeGatewayList

Signed-off-by: Giuseppe Maxia <[email protected]>
Giuseppe Maxia added 2 commits March 23, 2021 10:38
Merge branch 'master' into fix-egw-issue-363
c252a69 
Signed-off-by: Giuseppe Maxia <[email protected]>
Update CHANGELOG.md
d03a5de 
Signed-off-by: Giuseppe Maxia <[email protected]>
@dataclouder dataclouder marked this pull request as ready for review March 23, 2021 09:42
@dataclouder dataclouder changed the title Fix ege gateway list retrieval Fix edge gateway list retrieval Mar 23, 2021
lvirbalas
lvirbalas reviewed Mar 23, 2021
View reviewed changes
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why a new function as opposed to fixing the existing one to return all items?

@dataclouder
Copy link
Contributor Author

Why a new function as opposed to fixing the existing one to return all items?

It was a good opportunity to normalize the name with the convention that a query returning a list should be called Query+EntityType+List

lvirbalas
lvirbalas approved these changes Mar 23, 2021
View reviewed changes
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

BTW, how many usages of the old function do we have in the Terraform project?

Replace deprecated code
6bee667 
Signed-off-by: Giuseppe Maxia <[email protected]>
Didainius
Didainius approved these changes Mar 23, 2021
View reviewed changes
Copy link
Collaborator

@Didainius Didainius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@dataclouder
Copy link
Contributor Author

dataclouder commented Mar 23, 2021 •
edited
Loading

BTW, how many usages of the old function do we have in the Terraform project?

One. And it was changed.
But the old function was used indirectly through GetEdgeGatewayByName and GetEdgeGatewayById

@dataclouder dataclouder merged commit a140db6 into vmware:master Mar 23, 2021
@dataclouder dataclouder mentioned this pull request Mar 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lvirbalas lvirbalas lvirbalas approved these changes

@Didainius Didainius Didainius approved these changes

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dataclouder @lvirbalas @Didainius @vmwclabot