Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Org VDC Networks #292

Merged
merged 13 commits into from
Mar 19, 2020
Merged

Update Org VDC Networks #292

merged 13 commits into from
Mar 19, 2020

Conversation

dataclouder
Copy link
Contributor

@dataclouder dataclouder commented Mar 4, 2020 •
edited
Loading

Adds the ability of updating Org VDC networks in place. Until now, we could only remove and re-create them.

Added methods orgVdcNetwork.Update, orgVdcNetwork.UpdateAsync, and OrgVdcNetwork.Rename

Didainius
Didainius reviewed Mar 16, 2020
View reviewed changes
Copy link
Collaborator

@Didainius Didainius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not much comments from me. I will have a second look together with provider PR.

@dataclouder dataclouder marked this pull request as ready for review March 16, 2020 06:31
vbauzys
vbauzys reviewed Mar 16, 2020
View reviewed changes
Copy link
Contributor

@vbauzys vbauzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments :)

Add explicit refresh to Update functions
e524e24 
* Add refresh at the end of the functions for OrgVDCNetwork and
  EdgeGateway
* Update tests to check that the object is updated.
Didainius
Didainius approved these changes Mar 17, 2020
View reviewed changes
Copy link
Collaborator

@Didainius Didainius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests passed for me in 9.5

vbauzys
vbauzys approved these changes Mar 17, 2020
View reviewed changes
Copy link
Contributor

@vbauzys vbauzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, passed tests with 9.5

lvirbalas
lvirbalas approved these changes Mar 18, 2020
View reviewed changes
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I would only like to ask to extend the PR description (and commit message) to include narrative what was not possible before and what the additions allow to do now more specifically (from the perspective of casual user who will be reading this PR description after clicking link in the changelog after referencing it with the next release).

@dataclouder
Copy link
Contributor Author

LGTM, I would only like to ask to extend the PR description (and commit message) to include narrative what was not possible before and what the additions allow to do now more specifically (from the perspective of casual user who will be reading this PR description after clicking link in the changelog after referencing it with the next release).

Previously, we could not update networks: we had to remove and re-create them. That's what the Update functions are about

@dataclouder dataclouder merged commit bcfd6a2 into vmware:master Mar 19, 2020
@rathinikunj rathinikunj mentioned this pull request Apr 28, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lvirbalas lvirbalas lvirbalas approved these changes

@Didainius Didainius Didainius approved these changes

@vbauzys vbauzys vbauzys approved these changes

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dataclouder @lvirbalas @Didainius @vbauzys @vmwclabot @datacharmer