Fix data race in catalog/media upload reporting #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lvirbalas
approved these changes
Feb 11, 2020
govcd/upload.go
Outdated
|
|
||
| "github.com/vmware/go-vcloud-director/v2/types/v56" | ||
| "github.com/vmware/go-vcloud-director/v2/util" | ||
| ) | ||
|
|
||
| // mutemutexedProgress is a thread-safe structure to update and report progress during an UploadTask. | ||
| // | ||
| // Value must be read/written using Get/Set values insted of directly accessing the |
There was a problem hiding this comment.
This was a mess. Fixed it now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of https://github.com/terraform-providers/terraform-provider-vcd/issues/445 there is a small issue in upload reporting which may have data races. This is not a dangerous situation because all it does is prints out the progress, but still this has to be cleaned up.