Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support update of Edge configuration (except Edge Services) #287

Closed
wants to merge 1 commit into from
Closed

Support update of Edge configuration (except Edge Services) #287

wants to merge 1 commit into from

Conversation

slavaavr
Copy link
Contributor

@slavaavr slavaavr commented Feb 6, 2020

Hi there. This PR kind of related with this issue #202
I got it how you decided to implement Edge update, however, I think this method will not be needless. What do you think of it?

@dataclouder
Copy link
Contributor

dataclouder commented Feb 6, 2020

Thanks for your contribution.
We are already in the process of implementing a full update of Edge Gateway.
Although the update function is conceptually simple, it requires extensive additional testing to make sure we are covering all the cases.

The function that you propose will end up being a duplicate effort, and given that it doesn't come with tests, it will be of little value in these circumstances.

@slavaavr
Copy link
Contributor Author

slavaavr commented Feb 6, 2020

@dataclouder oh, I see. So, when do you think update function will be released (approximately)? And what I have to do with this PR, close it for now?

@datacharmer
Copy link
Contributor

I think you can close for now. We don't have an official release date yet, although our release cycles are usually 3 to 4 months

@slavaavr
Copy link
Contributor Author

slavaavr commented Feb 6, 2020

@datacharmer, i got it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants