Added vdc meta data functions #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vaidotas Bauzys <[email protected]>
vbauzys
requested review from
dataclouder,
lvirbalas and
Didainius
and removed request for
dataclouder and
lvirbalas
lvirbalas
reviewed
Jun 18, 2019
Signed-off-by: Vaidotas Bauzys <[email protected]>
dataclouder
suggested changes
Jun 26, 2019
govcd/metadata_test.go
Outdated
| check.Assert(err, IsNil) | ||
| for _, k := range metadata.MetadataEntry { | ||
| if k.Key == "key2" { | ||
| check.Errorf("metadata.MetadataEntry should not contain key: %s", k) |
There was a problem hiding this comment.
Instead of k, it should be k.Key
Didainius
requested changes
Jun 26, 2019
Signed-off-by: Vaidotas Bauzys <[email protected]>
Signed-off-by: Vaidotas Bauzys <[email protected]>
Signed-off-by: Vaidotas Bauzys <[email protected]> # Conflicts: # CHANGELOG.md # govcd/system.go # types/v56/types.go
Signed-off-by: Vaidotas Bauzys <[email protected]> # Conflicts: # CHANGELOG.md # govcd/system.go # types/v56/types.go
Signed-off-by: Vaidotas Bauzys <[email protected]>
…ector into vdc_metadata Signed-off-by: Vaidotas Bauzys <[email protected]> # Conflicts: # CHANGELOG.md
Didainius
reviewed
Jul 1, 2019
Signed-off-by: Vaidotas Bauzys <[email protected]>
Didainius
approved these changes
Jul 1, 2019
Signed-off-by: Vaidotas Bauzys <[email protected]>
Signed-off-by: Vaidotas Bauzys <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: https://github.com/terraform-providers/terraform-provider-vcd/issues/238
Functions for handling meta data for vDC.
Also from previous research added developed function for future -
QueryOrgVdcNetworkByName