Vendor update on removing remove eng.vmware.com #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sakthi Sundaram <[email protected]>
rocknes
reviewed
Oct 7, 2024
go.mod
Outdated
| github.com/vmware/cloud-provider-for-cloud-director v0.0.0-20240725204714-a0a0e916a5ed | ||
| github.com/vmware/go-vcloud-director/v2 v2.21.0 | ||
| github.com/vmware/go-vcloud-director/v2 v2.26.0-alpha.6 |
There was a problem hiding this comment.
v2.26.0 is already released right? can't we use a released version instead of an alpha version?
There was a problem hiding this comment.
I second this. We can use the 2.26.0 version that was released fairly recently.
There was a problem hiding this comment.
updated to release version. Thanks for bringing this up.
rocknes
approved these changes
Oct 7, 2024
arunmk
approved these changes
Oct 7, 2024
Signed-off-by: Sakthi Sundaram <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@arunmk @rocknes @lzichong
This change is