-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TKG 2.5.2 cluster template files #660
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 5 files reviewed, 2 unresolved discussions (waiting on @lzichong)
templates/cluster-template-v1.26.14-tkgv2.5.2-crs.yaml
line 92 at r1 (raw file):
dns: imageRepository: projects.packages.broadcom.com/tkg # image repository to pull the DNS image from imageTag: v1.9.3+vmware.22 # DNS image tag associated with the TKGm OVA used. This dns version is associated with TKG OVA using Kubernetes version v1.28.4.
v1.9.3_vmware.22
v1.26.14
templates/cluster-template-v1.26.14-tkgv2.5.2-crs.yaml
line 96 at r1 (raw file):
local: imageRepository: projects.packages.broadcom.com/tkg # image repository to pull the etcd image from imageTag: v3.5.12+vmware.5 # etcd image tag associated with the TKGm OVA used. This etcd version is associated with TKG OVA using Kubernetes version v1.28.4.
v3.5.12_vmware.5
v1.26.14
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 5 files reviewed, 3 unresolved discussions (waiting on @lzichong)
templates/cluster-template-v1.27.15-tkgv2.5.2-crs.yaml
line 96 at r1 (raw file):
local: imageRepository: projects.packages.broadcom.com/tkg # image repository to pull the etcd image from imageTag: v3.5.12+vmware.5 # etcd image tag associated with the TKGm OVA used. This etcd version is associated with TKG OVA using Kubernetes version v1.28.4.
v3.5.12_vmware.5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 5 files reviewed, 4 unresolved discussions (waiting on @lzichong)
templates/cluster-template-v1.28.11-tkgv2.5.2-crs.yaml
line 96 at r1 (raw file):
local: imageRepository: projects.packages.broadcom.com/tkg # image repository to pull the etcd image from imageTag: v3.5.12+vmware.5 # etcd image tag associated with the TKGm OVA used. This etcd version is associated with TKG OVA using Kubernetes version v1.28.4.
v3.5.12_vmware.5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 5 files reviewed, 5 unresolved discussions (waiting on @lzichong)
templates/cluster-template-v1.29.6-tkgv2.5.2-crs.yaml
line 96 at r1 (raw file):
local: imageRepository: projects.packages.broadcom.com/tkg # image repository to pull the etcd image from imageTag: v3.5.12+vmware.5 # etcd image tag associated with the TKGm OVA used. This etcd version is associated with TKG OVA using Kubernetes version v1.28.4.
v3.5.12_vmware.5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 5 files reviewed, 6 unresolved discussions (waiting on @lzichong)
templates/cluster-template-v1.30.2-tkgv2.5.2-crs.yaml
line 96 at r1 (raw file):
local: imageRepository: projects.packages.broadcom.com/tkg # image repository to pull the etcd image from imageTag: v3.5.12+vmware.5 # etcd image tag associated with the TKGm OVA used. This etcd version is associated with TKG OVA using Kubernetes version v1.28.4.
v3.5.12_vmware.5
Also, I notice there is a cluster-template-.yaml file for each k8 version. @arunmk Is this also required ? |
Updated the coredns/etcd versions to use However, for the Kubernetes version I left it as-is as our previous template files kept |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 10 files reviewed, 6 unresolved discussions (waiting on @lzichong)
templates/cluster-template-v1.26.14-tkgv2.5.2-crs.yaml
line 96 at r1 (raw file):
Previously, lzichong wrote…
Updated the coredns/etcd versions to use
_
instead of+
thanks!However, for the Kubernetes version I left it as-is as our previous template files kept
+vmware-...
Sorry. I meant, it is the comment that has incorrect k8 version in the imageTag: property.
"This etcd version is associated with TKG OVA using Kubernetes version v1.28.4."
Updated, thanks Sakthi! |
Description
Please provide a brief description of the changes proposed in this Pull Request
Checklist
API Changes
Are there API changes?
If yes, please fill in the below
./examples/capi-quickstart.yaml
?./infrastructure-vcd/v1.0.0/
?Issue
If applicable, please reference the relevant issue
Fixes #
This change is