Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TKG 2.5.2 cluster template files #660

Merged
merged 4 commits into from
Oct 7, 2024
Merged

Conversation

lzichong
Copy link
Contributor

@lzichong lzichong commented Oct 4, 2024

Description

Please provide a brief description of the changes proposed in this Pull Request

  • Add cluster-template-* files for TKG 2.5.2

Checklist

  • tested locally
  • updated any relevant dependencies
  • updated any relevant documentation or examples

API Changes

Are there API changes?

  • Yes
  • No

If yes, please fill in the below

  1. Updated conversions?
    • Yes
    • No
    • N/A
  2. Updated CRDs?
    • Yes
    • No
    • N/A
  3. Updated infrastructure-components.yaml?
    • Yes
    • No
    • N/A
  4. Updated ./examples/capi-quickstart.yaml?
    • Yes
    • No
    • N/A
  5. Updated necessary files under ./infrastructure-vcd/v1.0.0/?
    • Yes
    • No
    • N/A

Issue

If applicable, please reference the relevant issue

Fixes #


This change is Reviewable

@lzichong lzichong requested review from sakthisunda and arunmk October 4, 2024 19:18
Copy link
Collaborator

@arunmk arunmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@sakthisunda sakthisunda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 5 files reviewed, 2 unresolved discussions (waiting on @lzichong)


templates/cluster-template-v1.26.14-tkgv2.5.2-crs.yaml line 92 at r1 (raw file):

      dns:
        imageRepository: projects.packages.broadcom.com/tkg # image repository to pull the DNS image from
        imageTag: v1.9.3+vmware.22 # DNS image tag associated with the TKGm OVA used. This dns version is associated with TKG OVA using Kubernetes version v1.28.4.

v1.9.3_vmware.22

v1.26.14


templates/cluster-template-v1.26.14-tkgv2.5.2-crs.yaml line 96 at r1 (raw file):

        local:
          imageRepository: projects.packages.broadcom.com/tkg # image repository to pull the etcd image from
          imageTag: v3.5.12+vmware.5 # etcd image tag associated with the TKGm OVA used. This etcd version is associated with TKG OVA using Kubernetes version v1.28.4.

v3.5.12_vmware.5

v1.26.14

Copy link
Contributor

@sakthisunda sakthisunda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 5 files reviewed, 3 unresolved discussions (waiting on @lzichong)


templates/cluster-template-v1.27.15-tkgv2.5.2-crs.yaml line 96 at r1 (raw file):

        local:
          imageRepository: projects.packages.broadcom.com/tkg # image repository to pull the etcd image from
          imageTag: v3.5.12+vmware.5 # etcd image tag associated with the TKGm OVA used. This etcd version is associated with TKG OVA using Kubernetes version v1.28.4.

v3.5.12_vmware.5

Copy link
Contributor

@sakthisunda sakthisunda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 5 files reviewed, 4 unresolved discussions (waiting on @lzichong)


templates/cluster-template-v1.28.11-tkgv2.5.2-crs.yaml line 96 at r1 (raw file):

        local:
          imageRepository: projects.packages.broadcom.com/tkg # image repository to pull the etcd image from
          imageTag: v3.5.12+vmware.5 # etcd image tag associated with the TKGm OVA used. This etcd version is associated with TKG OVA using Kubernetes version v1.28.4.

v3.5.12_vmware.5

Copy link
Contributor

@sakthisunda sakthisunda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 5 files reviewed, 5 unresolved discussions (waiting on @lzichong)


templates/cluster-template-v1.29.6-tkgv2.5.2-crs.yaml line 96 at r1 (raw file):

        local:
          imageRepository: projects.packages.broadcom.com/tkg # image repository to pull the etcd image from
          imageTag: v3.5.12+vmware.5 # etcd image tag associated with the TKGm OVA used. This etcd version is associated with TKG OVA using Kubernetes version v1.28.4.

v3.5.12_vmware.5

Copy link
Contributor

@sakthisunda sakthisunda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 5 files reviewed, 6 unresolved discussions (waiting on @lzichong)


templates/cluster-template-v1.30.2-tkgv2.5.2-crs.yaml line 96 at r1 (raw file):

        local:
          imageRepository: projects.packages.broadcom.com/tkg # image repository to pull the etcd image from
          imageTag: v3.5.12+vmware.5 # etcd image tag associated with the TKGm OVA used. This etcd version is associated with TKG OVA using Kubernetes version v1.28.4.

v3.5.12_vmware.5

@sakthisunda
Copy link
Contributor

Also, I notice there is a cluster-template-.yaml file for each k8 version. @arunmk Is this also required ?

@lzichong
Copy link
Contributor Author

lzichong commented Oct 4, 2024

Reviewable status: 0 of 5 files reviewed, 2 unresolved discussions (waiting on @lzichong)

templates/cluster-template-v1.26.14-tkgv2.5.2-crs.yaml line 92 at r1 (raw file):

      dns:
        imageRepository: projects.packages.broadcom.com/tkg # image repository to pull the DNS image from
        imageTag: v1.9.3+vmware.22 # DNS image tag associated with the TKGm OVA used. This dns version is associated with TKG OVA using Kubernetes version v1.28.4.

v1.9.3_vmware.22

v1.26.14

templates/cluster-template-v1.26.14-tkgv2.5.2-crs.yaml line 96 at r1 (raw file):

        local:
          imageRepository: projects.packages.broadcom.com/tkg # image repository to pull the etcd image from
          imageTag: v3.5.12+vmware.5 # etcd image tag associated with the TKGm OVA used. This etcd version is associated with TKG OVA using Kubernetes version v1.28.4.

v3.5.12_vmware.5

v1.26.14

Updated the coredns/etcd versions to use _ instead of + thanks!

However, for the Kubernetes version I left it as-is as our previous template files kept +vmware-...

Copy link
Contributor

@sakthisunda sakthisunda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 10 files reviewed, 6 unresolved discussions (waiting on @lzichong)


templates/cluster-template-v1.26.14-tkgv2.5.2-crs.yaml line 96 at r1 (raw file):

Previously, lzichong wrote…

Updated the coredns/etcd versions to use _ instead of + thanks!

However, for the Kubernetes version I left it as-is as our previous template files kept +vmware-...

Sorry. I meant, it is the comment that has incorrect k8 version in the imageTag: property.
"This etcd version is associated with TKG OVA using Kubernetes version v1.28.4."

@lzichong
Copy link
Contributor Author

lzichong commented Oct 7, 2024

Reviewable status: 0 of 10 files reviewed, 6 unresolved discussions (waiting on @lzichong)

templates/cluster-template-v1.26.14-tkgv2.5.2-crs.yaml line 96 at r1 (raw file):

Previously, lzichong wrote…
Sorry. I meant, it is the comment that has incorrect k8 version in the imageTag: property. "This etcd version is associated with TKG OVA using Kubernetes version v1.28.4."

Updated, thanks Sakthi!

@lzichong lzichong merged commit 4ba8334 into vmware:1.3.z Oct 7, 2024
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants