Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CAFV-448] TKG 2.5 templates for clusterctl #606

Merged
merged 3 commits into from
Mar 6, 2024
Merged

[CAFV-448] TKG 2.5 templates for clusterctl #606

merged 3 commits into from
Mar 6, 2024

Conversation

sakthisunda
Copy link
Contributor

@sakthisunda sakthisunda commented Mar 6, 2024 •
edited by goelaashima
Loading

Description

TKG 2.5 templates for clusterctl

Checklist

  • tested locally
  • updated any relevant dependencies
  • updated any relevant documentation or examples

API Changes

Are there API changes?

  • Yes
  • [ X] No

If yes, please fill in the below

  1. Updated conversions?

    • Yes
    • [X ] No
    • N/A

  2. Updated CRDs?

    • Yes
    • No
    • N/A

  3. Updated infrastructure-components.yaml?

    • Yes
    • [ X] No
    • N/A

  4. Updated ./examples/capi-quickstart.yaml?

    • Yes
    • [ X] No
    • N/A

  5. Updated necessary files under ./infrastructure-vcd/v1.0.0/?

    • N/A

Issue

NA
Fixes #
NA

This change is Reviewable

@sakthisunda
tkg 2.5.0 placeholder files
acbbd74 
Signed-off-by: Sakthi Sundaram <[email protected]>
@sakthisunda
updated coredns, etc and k8 versions
4272c4c 
Signed-off-by: Sakthi Sundaram <[email protected]>
@sakthisunda sakthisunda self-assigned this Mar 6, 2024
arunmk
arunmk approved these changes Mar 6, 2024
View reviewed changes
Copy link
Collaborator

@arunmk arunmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the change requested in the comment file.

templates/cluster-template-v1.26.11-tkgv2.5.0-crs.yaml Outdated
- 127.0.0.1
dns:
imageRepository: projects.registry.vmware.com/tkg # image repository to pull the DNS image from
imageTag: v1.9.3_vmware.19 # DNS image tag associated with the TKGm OVA used. This dns version is associated with TKG OVA using Kubernetes version v1.25.7.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description should refer to 1.26.11 for this file, and the appropriate versions for the other files

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

lzichong
lzichong approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@lzichong lzichong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:, agreed with Arun as well where we should ensure the commented versions matches the actual version

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Anirudh9794 and @sakthisunda)

sakthisunda
sakthisunda commented Mar 6, 2024
View reviewed changes
Copy link
Contributor Author

@sakthisunda sakthisunda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

versions in the comment now match the actuals

Reviewable status: 0 of 6 files reviewed, 1 unresolved discussion (waiting on @Anirudh9794 and @lzichong)

sakthisunda
sakthisunda commented Mar 6, 2024
View reviewed changes
Copy link
Contributor Author

@sakthisunda sakthisunda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 6 files reviewed, 1 unresolved discussion (waiting on @Anirudh9794, @arunmk, and @lzichong)

templates/cluster-template-v1.26.11-tkgv2.5.0-crs.yaml line 89 at r1 (raw file):

Previously, arunmk (Arun M. Krishnakumar) wrote…

The description should refer to 1.26.11 for this file, and the appropriate versions for the other files

Done.

@sakthisunda sakthisunda merged commit a975aee into vmware:main Mar 6, 2024
1 check was pending
@sakthisunda sakthisunda changed the title [VCDA-7218] TKG 2.5 templates for clusterctl [CAFV-448] TKG 2.5 templates for clusterctl Mar 6, 2024
sakthisunda added a commit to sakthisunda/cluster-api-provider-cloud-director that referenced this pull request Mar 7, 2024
@sakthisunda
[VCDA-7218] TKG 2.5 templates for clusterctl (vmware#606)
ec93489 
* tkg 2.5.0 placeholder files

Signed-off-by: Sakthi Sundaram <[email protected]>

* updated coredns, etc and k8 versions

Signed-off-by: Sakthi Sundaram <[email protected]>

* update the component versions in the comment to match the actuals

Signed-off-by: Sakthi Sundaram <[email protected]>

---------

Signed-off-by: Sakthi Sundaram <[email protected]>
(cherry picked from commit a975aee)
sakthisunda added a commit to sakthisunda/cluster-api-provider-cloud-director that referenced this pull request Mar 7, 2024
@sakthisunda
[VCDA-7218] TKG 2.5 templates for clusterctl (vmware#606)
5d48bd0 
* tkg 2.5.0 placeholder files

Signed-off-by: Sakthi Sundaram <[email protected]>

* updated coredns, etc and k8 versions

Signed-off-by: Sakthi Sundaram <[email protected]>

* update the component versions in the comment to match the actuals

Signed-off-by: Sakthi Sundaram <[email protected]>

---------

Signed-off-by: Sakthi Sundaram <[email protected]>
(cherry picked from commit a975aee)
sakthisunda added a commit that referenced this pull request Mar 7, 2024
@sakthisunda
[VCDA-7218] TKG 2.5 templates for clusterctl (#606) (#607)
a3b0c7b 
* tkg 2.5.0 placeholder files

Signed-off-by: Sakthi Sundaram <[email protected]>

* updated coredns, etc and k8 versions

Signed-off-by: Sakthi Sundaram <[email protected]>

* update the component versions in the comment to match the actuals

Signed-off-by: Sakthi Sundaram <[email protected]>

---------

Signed-off-by: Sakthi Sundaram <[email protected]>
(cherry picked from commit a975aee)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arunmk arunmk arunmk approved these changes

@lzichong lzichong lzichong approved these changes

@Anirudh9794 Anirudh9794 Awaiting requested review from Anirudh9794

Assignees

@sakthisunda sakthisunda

Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sakthisunda @arunmk @lzichong @vmwclabot