[CAFV-443] Consume latest common-core from CPI 1.6.0 to enable IP space support #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 14, 2024 15:22
…12a126836606 Signed-off-by: Aritra Sen <[email protected]>
…hanges made to them in CPI for IP space support Signed-off-by: Aritra Sen <[email protected]>
lzichong
approved these changes
Feb 15, 2024
There was a problem hiding this comment.
Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Anirudh9794, @arunmk, and @sahithi)
Anirudh9794
reviewed
Feb 20, 2024
There was a problem hiding this comment.
Reviewable status:
arunmk
approved these changes
Feb 20, 2024
arunmk
approved these changes
Feb 20, 2024
rocknes
added a commit
that referenced
this pull request
Feb 20, 2024
…le IP space support (#599) (#602) Refresh common core from CPI main branch. Update gateway code to consume IP space related changes in common core. (commit : ba3f236) --------- Signed-off-by: Aritra Sen <[email protected]> Co-authored-by: Aritra Sen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Consume latest common-core from CPI 1.6.0 to enable IP space support
CPI commit : af504c145ad5ff8485682b0fd67d12a126836606
Updated references of gateway.CreateLoadBalancer, gateway.DeleteLoadBalancer to consume IP space support in those methods
Checklist
API Changes
Are there API changes?
If yes, please fill in the below
./examples/capi-quickstart.yaml?./infrastructure-vcd/v1.0.0/?Issue
If applicable, please reference the relevant issue
Fixes #
This change is