Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAFV-326: Make EnableNVidiaGPU into a no-op (#524) #525

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

arunmk
Copy link
Collaborator

@arunmk arunmk commented Oct 10, 2023

  • Do not customize VM even if EnableNvidiaGPU is set up. The customization that we performed was (slightly) helping customers who would install GPU drivers in GPU nodes directly. However this interferes with the NVIDIA GPU operator functionality.
  • Those customers who would install GPU drivers in GPU nodes directly will be impacted by this change. However they can include the customization into their workflow directly since it is a very small customization
  • Note that the flag has not yet been deprecated. The next API update should begin to show the deprecation.

(cherry picked from commit a5ab47d)

Description

Please provide a brief description of the changes proposed in this Pull Request

Checklist

  • tested locally
  • updated any relevant dependencies
  • updated any relevant documentation or examples

API Changes

Are there API changes?

  • Yes
  • No

If yes, please fill in the below

  1. Updated conversions?
    • Yes
    • No
    • N/A
  2. Updated CRDs?
    • Yes
    • No
    • N/A
  3. Updated infrastructure-components.yaml?
    • Yes
    • No
    • N/A
  4. Updated ./examples/capi-quickstart.yaml?
    • Yes
    • No
    • N/A
  5. Updated necessary files under ./infrastructure-vcd/v1.0.0/?
    • Yes
    • No
    • N/A

Issue

If applicable, please reference the relevant issue

Fixes #CAFV-326 on 1.1.z branch


This change is Reviewable

- Do not customize VM even if EnableNvidiaGPU is set up. The customization that we performed was (slightly) helping customers who would install GPU drivers in GPU nodes directly. However this interferes with the NVIDIA GPU operator functionality.
- Those customers who would install GPU drivers in GPU nodes directly will be impacted by this change. However they can include the customization into their workflow directly since it is a very small customization
- Note that the flag has not yet been deprecated. The next API update should begin to show the deprecation.

(cherry picked from commit a5ab47d)
Copy link
Contributor

@lzichong lzichong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @abaruni and @sakthisunda)

Copy link
Contributor

@abaruni abaruni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @sakthisunda)

@arunmk arunmk merged commit 1d7c39b into vmware:1.1.z Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants