Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CAFV-290] add clusterctl templates for 1.24 and 1.25 versions #476

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

ymo24
Copy link
Contributor

@ymo24 ymo24 commented Jul 11, 2023

Description

Please provide a brief description of the changes proposed in this Pull Request

  • add clusterctl templates for 1.24 and 1.25 versions

Checklist

  • tested locally
  • updated any relevant dependencies
  • updated any relevant documentation or examples

API Changes

Are there API changes?

  • Yes
  • No

If yes, please fill in the below

  1. Updated conversions?
    • Yes
    • No
    • N/A
  2. Updated CRDs?
    • Yes
    • No
    • N/A
  3. Updated infrastructure-components.yaml?
    • Yes
    • No
    • N/A
  4. Updated ./examples/capi-quickstart.yaml?
    • Yes
    • No
    • N/A
  5. Updated necessary files under ./infrastructure-vcd/v1.0.0/?
    • Yes
    • No
    • N/A

Issue

If applicable, please reference the relevant issue

Fixes #


This change is Reviewable

@ymo24 ymo24 self-assigned this Jul 11, 2023
Copy link
Contributor

@Anirudh9794 Anirudh9794 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @lzichong and @sahithi)

Copy link
Contributor

@lzichong lzichong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @sahithi)

@ymo24 ymo24 merged commit 0ed458a into vmware:main Jul 11, 2023
@ymo24 ymo24 deleted the CAFV-290 branch July 11, 2023 18:48
ymo24 added a commit to ymo24/cluster-api-provider-cloud-director that referenced this pull request Jul 11, 2023
ymo24 added a commit that referenced this pull request Jul 12, 2023
…#478)

* [CAFV-290] add clusterctl templates for 1.24 and 1.25 versions (#476)

Signed-off-by: ymo24 <[email protected]>
(cherry picked from commit 0ed458a)

* [CAFV-290] catch up missing content (#477)

Signed-off-by: ymo24 <[email protected]>
(cherry picked from commit 65e29fd)
ymo24 added a commit to ymo24/cluster-api-provider-cloud-director that referenced this pull request Aug 28, 2023
lzichong pushed a commit to lzichong/cluster-api-provider-cloud-director that referenced this pull request Aug 28, 2023
ymo24 added a commit to ymo24/cluster-api-provider-cloud-director that referenced this pull request Aug 28, 2023
ymo24 added a commit that referenced this pull request Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants