Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CAFV-252] Bump cluster-api to v1.4.0 along with other dependencies needed for v1.4.0 #445

Merged
merged 3 commits into from
May 25, 2023

Conversation

lzichong
Copy link
Contributor

@lzichong lzichong commented May 12, 2023

Description

Please provide a brief description of the changes proposed in this Pull Request

  • Update go.mod to use cluster-api v1.4.0, and other dependencies consumed by it, such as controller-runtime, ginkgo, etc.
  • Update vcdmachine_controllers.go, capi_object_utils.go to use updated label constants

Checklist

  • tested locally – Built image locally with Go 1.19, and created cluster using core-capi v1.4.0 + local CAPVCD build.
  • updated any relevant dependencies
  • updated any relevant documentation or examples

API Changes

Are there API changes?

  • Yes
  • No

If yes, please fill in the below

  1. Updated conversions?
    • Yes
    • No
    • N/A
  2. Updated CRDs?
    • Yes
    • No
    • N/A
  3. Updated infrastructure-components.yaml?
    • Yes
    • No
    • N/A
  4. Updated ./examples/capi-quickstart.yaml?
    • Yes
    • No
    • N/A
  5. Updated necessary files under ./infrastructure-vcd/v1.0.0/?
    • Yes
    • No
    • N/A

Issue

If applicable, please reference the relevant issue

Fixes #


This change is Reviewable

Copy link
Collaborator

@sahithi sahithi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1522 of 1522 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Anirudh9794 and @arunmk)

Copy link
Contributor

@Anirudh9794 Anirudh9794 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 10 of 1522 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @arunmk)

@lzichong lzichong merged commit 231fca1 into vmware:main May 25, 2023
ymo24 pushed a commit to ymo24/cluster-api-provider-cloud-director that referenced this pull request May 30, 2023
…eeded for v1.4.0 (vmware#445)

* Bump cluster-api to v1.4.0 along with their required dependencies

Signed-off-by: lzichong <[email protected]>

* Update vcdmachine controller labels, and remove pkg/envtest/printer usage as it's no longer present

Signed-off-by: lzichong <[email protected]>

* Update label constants in capi object utils

Signed-off-by: lzichong <[email protected]>

---------

Signed-off-by: lzichong <[email protected]>
(cherry picked from commit 231fca1)
ymo24 pushed a commit to ymo24/cluster-api-provider-cloud-director that referenced this pull request Aug 28, 2023
…eeded for v1.4.0 (vmware#445)

* Bump cluster-api to v1.4.0 along with their required dependencies

Signed-off-by: lzichong <[email protected]>

* Update vcdmachine controller labels, and remove pkg/envtest/printer usage as it's no longer present

Signed-off-by: lzichong <[email protected]>

* Update label constants in capi object utils

Signed-off-by: lzichong <[email protected]>

---------

Signed-off-by: lzichong <[email protected]>
lzichong added a commit to lzichong/cluster-api-provider-cloud-director that referenced this pull request Aug 28, 2023
…eeded for v1.4.0 (vmware#445)

* Bump cluster-api to v1.4.0 along with their required dependencies

Signed-off-by: lzichong <[email protected]>

* Update vcdmachine controller labels, and remove pkg/envtest/printer usage as it's no longer present

Signed-off-by: lzichong <[email protected]>

* Update label constants in capi object utils

Signed-off-by: lzichong <[email protected]>

---------

Signed-off-by: lzichong <[email protected]>
ymo24 pushed a commit to ymo24/cluster-api-provider-cloud-director that referenced this pull request Aug 28, 2023
…eeded for v1.4.0 (vmware#445)

* Bump cluster-api to v1.4.0 along with their required dependencies

Signed-off-by: lzichong <[email protected]>

* Update vcdmachine controller labels, and remove pkg/envtest/printer usage as it's no longer present

Signed-off-by: lzichong <[email protected]>

* Update label constants in capi object utils

Signed-off-by: lzichong <[email protected]>

---------

Signed-off-by: lzichong <[email protected]>
ymo24 pushed a commit that referenced this pull request Aug 28, 2023
…eeded for v1.4.0 (#445)

* Bump cluster-api to v1.4.0 along with their required dependencies

Signed-off-by: lzichong <[email protected]>

* Update vcdmachine controller labels, and remove pkg/envtest/printer usage as it's no longer present

Signed-off-by: lzichong <[email protected]>

* Update label constants in capi object utils

Signed-off-by: lzichong <[email protected]>

---------

Signed-off-by: lzichong <[email protected]>
dlipovetsky added a commit to mesosphere/cluster-api-provider-cloud-director that referenced this pull request Sep 20, 2023
A recent PR[1] updated the godoc comment that describes the
VCDMachineSpec MachineAddress field, but the change was not reflected in
the v1beta1 CRD.

[1]: vmware#445
dlipovetsky added a commit to mesosphere/cluster-api-provider-cloud-director that referenced this pull request Sep 20, 2023
A recent PR[1] updated the godoc comment that describes the
VCDMachineSpec MachineAddress field, but the change was not reflected in
the v1beta1 CRD.

[1]: vmware#445
dlipovetsky added a commit to mesosphere/cluster-api-provider-cloud-director that referenced this pull request Sep 20, 2023
A recent PR[1] updated the godoc comment that describes the
VCDMachineSpec MachineAddress field, but the change was not reflected in
the v1beta1 CRD.

This updates the comment in the CRD base, as well as
infrastructure-components.yaml

[1]: vmware#445
dlipovetsky added a commit to mesosphere/cluster-api-provider-cloud-director that referenced this pull request Sep 20, 2023
A recent PR[1] updated the godoc comment that describes the
VCDMachineSpec MachineAddress field, but the change was not reflected in
the v1beta1 CRD.

This updates the comment in the CRD base, as well as
infrastructure-components.yaml

[1]: vmware#445
dlipovetsky added a commit to mesosphere/cluster-api-provider-cloud-director that referenced this pull request Sep 20, 2023
A recent PR[1] updated the godoc comment that describes the
VCDMachineSpec MachineAddress field, but the change was not reflected in
the v1beta1 CRD.

This updates the comment in the CRD base, as well as
infrastructure-components.yaml

[1]: vmware#445
dlipovetsky added a commit to mesosphere/cluster-api-provider-cloud-director that referenced this pull request Sep 22, 2023
A recent PR[1] updated the godoc comment that describes the
VCDMachineSpec MachineAddress field, but the change was not reflected in
the v1beta1 CRD.

This updates the comment in the CRD base, as well as
infrastructure-components.yaml

[1]: vmware#445
dlipovetsky added a commit to mesosphere/cluster-api-provider-cloud-director that referenced this pull request Oct 18, 2023
A recent PR[1] updated the godoc comment that describes the
VCDMachineSpec MachineAddress field, but the change was not reflected in
the v1beta1 CRD.

This updates the comment in the CRD base, as well as
infrastructure-components.yaml

[1]: vmware#445
kaiwalyajoshi pushed a commit to mesosphere/cluster-api-provider-cloud-director that referenced this pull request Mar 7, 2024
A recent PR[1] updated the godoc comment that describes the
VCDMachineSpec MachineAddress field, but the change was not reflected in
the v1beta1 CRD.

This updates the comment in the CRD base, as well as
infrastructure-components.yaml

[1]: vmware#445
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants