-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CAFV-246] upgrade go version to 1.19 #440
Conversation
Signed-off-by: ymo24 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @arunmk)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ymo24)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ymo24)
Makefile
line 93 at r1 (raw file):
vendor: ## Run go mod vendor go mod edit -go=1.19 go mod tidy -compat=1.17
Shouldn't this also be 1.19?
Signed-off-by: ymo24 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 4 of 5 files reviewed, 1 unresolved discussion (waiting on @abaruni and @arunmk)
Makefile
line 93 at r1 (raw file):
Previously, arunmk (Arun M. Krishnakumar) wrote…
Shouldn't this also be 1.19?
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: 4 of 5 files reviewed, all discussions resolved (waiting on @abaruni)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ymo24)
* upgrade go version to 1.19 Signed-off-by: ymo24 <[email protected]> * address minor fix Signed-off-by: ymo24 <[email protected]> --------- Signed-off-by: ymo24 <[email protected]>
* upgrade go version to 1.19 Signed-off-by: ymo24 <[email protected]> * address minor fix Signed-off-by: ymo24 <[email protected]> --------- Signed-off-by: ymo24 <[email protected]>
* upgrade go version to 1.19 Signed-off-by: ymo24 <[email protected]> * address minor fix Signed-off-by: ymo24 <[email protected]> --------- Signed-off-by: ymo24 <[email protected]>
* upgrade go version to 1.19 Signed-off-by: ymo24 <[email protected]> * address minor fix Signed-off-by: ymo24 <[email protected]> --------- Signed-off-by: ymo24 <[email protected]>
Description
Please provide a brief description of the changes proposed in this Pull Request
Checklist
API Changes
Are there API changes?
If yes, please fill in the below
./examples/capi-quickstart.yaml
?./infrastructure-vcd/v1.0.0/
?Issue
If applicable, please reference the relevant issue
Fixes #
This change is