Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CAFV-246] upgrade go version to 1.19 #440

Merged
merged 2 commits into from
May 10, 2023
Merged

[CAFV-246] upgrade go version to 1.19 #440

merged 2 commits into from
May 10, 2023

Conversation

ymo24
Copy link
Contributor

@ymo24 ymo24 commented May 3, 2023

Description

Please provide a brief description of the changes proposed in this Pull Request

  • Upgrade golang version to 1.19
    • go mod edit -go=1.19
    • go mod tidy
    • go mod vendor

Checklist

  • tested locally
  • updated any relevant dependencies
  • updated any relevant documentation or examples

API Changes

Are there API changes?

  • Yes
  • No

If yes, please fill in the below

  1. Updated conversions?
    • Yes
    • No
    • N/A
  2. Updated CRDs?
    • Yes
    • No
    • N/A
  3. Updated infrastructure-components.yaml?
    • Yes
    • No
    • N/A
  4. Updated ./examples/capi-quickstart.yaml?
    • Yes
    • No
    • N/A
  5. Updated necessary files under ./infrastructure-vcd/v1.0.0/?
    • Yes
    • No
    • N/A

Issue

If applicable, please reference the relevant issue

Fixes #


This change is Reviewable

Copy link
Contributor

@abaruni abaruni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @arunmk)

Copy link
Collaborator

@arunmk arunmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ymo24)

Copy link
Collaborator

@arunmk arunmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ymo24)


Makefile line 93 at r1 (raw file):

vendor: ## Run go mod vendor
	go mod edit -go=1.19
	go mod tidy -compat=1.17

Shouldn't this also be 1.19?

Signed-off-by: ymo24 <[email protected]>
Copy link
Contributor Author

@ymo24 ymo24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 4 of 5 files reviewed, 1 unresolved discussion (waiting on @abaruni and @arunmk)


Makefile line 93 at r1 (raw file):

Previously, arunmk (Arun M. Krishnakumar) wrote…

Shouldn't this also be 1.19?

Done.

Copy link
Collaborator

@arunmk arunmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed all commit messages.
Reviewable status: 4 of 5 files reviewed, all discussions resolved (waiting on @abaruni)

Copy link
Contributor

@abaruni abaruni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ymo24)

@ymo24 ymo24 merged commit a647055 into vmware:main May 10, 2023
@ymo24 ymo24 deleted the CAFV-246 branch May 10, 2023 22:58
ymo24 added a commit to ymo24/cluster-api-provider-cloud-director that referenced this pull request Aug 28, 2023
* upgrade go version to 1.19

Signed-off-by: ymo24 <[email protected]>

* address minor fix

Signed-off-by: ymo24 <[email protected]>

---------

Signed-off-by: ymo24 <[email protected]>
lzichong pushed a commit to lzichong/cluster-api-provider-cloud-director that referenced this pull request Aug 28, 2023
* upgrade go version to 1.19

Signed-off-by: ymo24 <[email protected]>

* address minor fix

Signed-off-by: ymo24 <[email protected]>

---------

Signed-off-by: ymo24 <[email protected]>
ymo24 added a commit to ymo24/cluster-api-provider-cloud-director that referenced this pull request Aug 28, 2023
* upgrade go version to 1.19

Signed-off-by: ymo24 <[email protected]>

* address minor fix

Signed-off-by: ymo24 <[email protected]>

---------

Signed-off-by: ymo24 <[email protected]>
ymo24 added a commit that referenced this pull request Aug 28, 2023
* upgrade go version to 1.19

Signed-off-by: ymo24 <[email protected]>

* address minor fix

Signed-off-by: ymo24 <[email protected]>

---------

Signed-off-by: ymo24 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants