Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant import, making the code base compilable again #361

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

jonkerj
Copy link
Contributor

@jonkerj jonkerj commented Dec 7, 2022

Description

#254 erroneously re-introduced the import of io/ioutil, which had been removed previously. Go complains about it, because it is not used since 73b198a, rendering the code base uncompilable.

This commit fixes that, and it is able to compile again.

Checklist

  • tested locally
  • updated any relevant dependencies
  • updated any relevant documentation or examples

API Changes

Are there API changes?

  • Yes
  • No

If yes, please fill in the below

  1. Updated conversions?
    • Yes
    • No
    • N/A
  2. Updated CRDs?
    • Yes
    • No
    • N/A
  3. Updated infrastructure-components.yaml?
    • Yes
    • No
    • N/A
  4. Updated ./examples/capi-quickstart.yaml?
    • Yes
    • No
    • N/A
  5. Updated necessary files under ./infrastructure-vcd/v1.0.0/?
    • Yes
    • No
    • N/A

Issue

n/a, I could open one, if needed.


This change is Reviewable

73b198a erroneously re-introduced the import of `io/ioutil`, which had
been removed previously. Go complains about it, because it is not used
since 73b198a, rendering the code base uncompilable.

This commit fixes that, and it is able to compile again.

Signed-off-by: Jorik Jonker <[email protected]>
@vmwclabot
Copy link
Member

@jonkerj, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

@vmwclabot
Copy link
Member

@jonkerj, we have received your signed contributor license agreement. It will be reviewed by VMware shortly. Another comment will be added to the pull request to notify you when the merge can proceed.

@vmwclabot
Copy link
Member

@jonkerj, VMware has approved your signed contributor license agreement.

@arunmk arunmk merged commit be58b36 into vmware:main Dec 12, 2022
@arunmk
Copy link
Collaborator

arunmk commented Dec 12, 2022

Thanks @jonkerj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants