Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VCDA-4088: Add NodeGetVolumeStats for volume metrics #75

Merged
merged 1 commit into from
Jul 18, 2022

Conversation

arunmk
Copy link
Collaborator

@arunmk arunmk commented Jul 16, 2022

Fixes #62


This change is Reviewable

Unit: csi.VolumeUsage_BYTES,
},
{
Available: int64(statFS.Ffree),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, Why are there exactly two elements in the array?

Copy link

@erdembas erdembas Jul 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CSI expects this. The first shares the byte statistics and the second shares the index node (inode) statistics. This is how the Kubernetes container storage interface expects a return. @Anirudh9794

Copy link
Contributor

@ymo24 ymo24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @arunmk)

@arunmk arunmk merged commit c3ad640 into vmware:main Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Volume metrics
5 participants