Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VM datastore value when the datastore name has space #623

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

keirazhang
Copy link
Contributor

When the datastore name has space like datastore2 (1), the value of datastore set in common/vm_get_vm_info.yml remove the space and characters following it, like datastore2.
This fix is to correct VM's datastore value.

Datastore name has space

TASK [Display VM's basic information] ************************************************************************************************************************************************************************************************
task path: /home/qiz/workspace/github/ansible-vsphere-gos-validation/common/vm_get_vm_info.yml:28
ok: [localhost] => {
    "msg": [
        "VM datastore: datastore2 (1)",
        "VM files path: /vmfs/volumes/datastore2 (1)/LinuxMint-22-Xfce-EFI-Tools-HW20/",
        "VM files path: [datastore2 (1)] LinuxMint-22-Xfce-EFI-Tools-HW20/",
        "VM directory name: LinuxMint-22-Xfce-EFI-Tools-HW20",
        "VM vmx file path: /vmfs/volumes/datastore2 (1)/LinuxMint-22-Xfce-EFI-Tools-HW20/LinuxMint-22-Xfce-EFI-Tools-HW20.vmx",
        "VM guest ID: other6xLinux64Guest",
        "VM hardware version: vmx-20",
        "VM hardware version number: 20",
        "VM firmware: efi"
    ]

Datastore name has no space

TASK [Display VM's basic information] ************************************************************************************************************************************************************************************************
task path: /home/qiz/workspace/github/ansible-vsphere-gos-validation/common/vm_get_vm_info.yml:28
ok: [localhost] => {
    "msg": [
        "VM datastore: datastore3",
        "VM files path: /vmfs/volumes/datastore3/rhel-10-debug_cpu_latency/",
        "VM files path: [datastore3] rhel-10-debug_cpu_latency/",
        "VM directory name: rhel-10-debug_cpu_latency",
        "VM vmx file path: /vmfs/volumes/datastore3/rhel-10-debug_cpu_latency/rhel-10-debug_cpu_latency.vmx",
        "VM guest ID: rhel8_64Guest",
        "VM hardware version: vmx-22",
        "VM hardware version number: 22",
        "VM firmware: efi"
    ]
}

@keirazhang keirazhang added this to the 3.2 milestone Aug 15, 2024
Copy link
Member

@Tomorrow9 Tomorrow9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@keirazhang keirazhang merged commit d56c24d into vmware:main Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants