Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Linux] Add config option 'without-x' for installing open-vm-tools from source on Ubuntu 24.04 #621

Merged
merged 3 commits into from
Aug 15, 2024

Conversation

keirazhang
Copy link
Contributor

@keirazhang keirazhang commented Aug 14, 2024

  1. Ubuntu 24.04 has upgraded gtk and gtkmm version, which would led to MKS related function issue. This fix is to skip compiling about X plugins on Ubuntu 24.04.
  2. Ubuntu 24.04 desktop installed ubuntu-desktop-minimal not ubuntu-desktop. So I also updated the edition check by searching for packages like ubuntu-server or ubuntu-desktop.
  3. When cloud-init is not installed, command /usr/bin/cloud-init --version 2>&1 failed, but with the pipe ` | awk '{print $2}', its rc is 0. So this fix also checked the cloud-init binary exists or not before getting cloud-init version.
+--------------------------------------------------------------------------+
| GuestInfo Detailed Data   | architecture='X86'                           |
|                           | bitness='64'                                 |
|                           | distroAddlVersion='24.04 LTS (Noble Numbat)' |
|                           | distroName='Ubuntu'                          |
|                           | distroVersion='24.04'                        |
|                           | familyName='Linux'                           |
|                           | kernelVersion='6.8.0-40-generic'             |
|                           | prettyName='Ubuntu 24.04 LTS'                |
+--------------------------------------------------------------------------+


Test Results (Total: 1, Passed: 1, Elapsed Time: 00:19:08)
+--------------------------------------------------+
| ID | Name                   | Status | Exec Time |
+--------------------------------------------------+
|  1 | ovt_verify_src_install | Passed | 00:18:42  |
+--------------------------------------------------+
+-------------------------------------------------------------------------+
| GuestInfo Detailed Data   | architecture='X86'                          |
|                           | bitness='64'                                |
|                           | distroAddlVersion='12 (bookworm)'           |
|                           | distroName='Debian GNU/Linux'               |
|                           | distroVersion='12'                          |
|                           | familyName='Linux'                          |
|                           | kernelVersion='6.1.0-22-amd64'              |
|                           | prettyName='Debian GNU/Linux 12 (bookworm)' |
+-------------------------------------------------------------------------+


Test Results (Total: 3, Passed: 3, Elapsed Time: 01:29:43)
+-----------------------------------------------------+
| ID | Name                      | Status | Exec Time |
+-----------------------------------------------------+
|  1 | deploy_vm_bios_ide_e1000e | Passed | 00:57:06  |
|  2 | check_inbox_driver        | Passed | 00:01:36  |
|  3 | ovt_verify_src_install    | Passed | 00:30:41  |
+-----------------------------------------------------+
+---------------------------------------------------------------------+
| GuestInfo Detailed Data   | architecture='X86'                      |
|                           | bitness='64'                            |
|                           | cpeString='cpe:/o:opensuse:leap:15.6'   |
|                           | distroAddlVersion='15.6'                |
|                           | distroName='openSUSE Leap'              |
|                           | distroVersion='15.6'                    |
|                           | familyName='Linux'                      |
|                           | kernelVersion='6.4.0-150600.21-default' |
|                           | prettyName='openSUSE Leap 15.6'         |
+---------------------------------------------------------------------+


Test Results (Total: 3, Passed: 3, Elapsed Time: 01:01:33)
+-------------------------------------------------------------+
| ID | Name                              | Status | Exec Time |
+-------------------------------------------------------------+
|  1 | deploy_vm_efi_paravirtual_vmxnet3 | Passed | 00:38:50  |
|  2 | check_inbox_driver                | Passed | 00:03:20  |
|  3 | ovt_verify_src_install            | Passed | 00:19:01  |
+-------------------------------------------------------------+

@keirazhang keirazhang added this to the 3.2 milestone Aug 14, 2024
Copy link
Member

@Tomorrow9 Tomorrow9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@keirazhang keirazhang merged commit 2c4c1bd into vmware:main Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants