Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Linux] Enable cloud-init services after modifying configs for cloud-init GOSC #613

Merged
merged 4 commits into from
Jul 24, 2024

Conversation

keirazhang
Copy link
Contributor

Stop and enable services might cause failures on Ubuntu OS. This fix is to separate service operations for enabling cloud-init GOSC. Firstly, stop cloud-init services, then modify cloud-init configs, and after that enable cloud-init services.

@keirazhang keirazhang added this to the 3.2 milestone Jul 17, 2024
@keirazhang keirazhang force-pushed the fix_ubuntu_cloudinit branch from 03ac7c8 to 2f7ae61 Compare July 17, 2024 08:11
123lzxm
123lzxm previously approved these changes Jul 17, 2024
Copy link
Collaborator

@123lzxm 123lzxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

linux/setup/test_setup.yml Outdated Show resolved Hide resolved
linux/utils/install_uninstall_package.yml Outdated Show resolved Hide resolved
@keirazhang keirazhang force-pushed the fix_ubuntu_cloudinit branch from 609a6a9 to 607159f Compare July 22, 2024 01:44
@keirazhang
Copy link
Contributor Author

@Tomorrow9 @123lzxm any new comments about this PR?

@keirazhang keirazhang force-pushed the fix_ubuntu_cloudinit branch from 607159f to 22fbc11 Compare July 24, 2024 07:08
Copy link
Member

@Tomorrow9 Tomorrow9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@keirazhang keirazhang merged commit f28510b into vmware:main Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants