-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Linux] Update GOSC test scope and handle known issues with workaround #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keirazhang
force-pushed
the
fix_centos10_gosc
branch
from
July 10, 2024 02:52
2c8c5ce
to
83cb9a1
Compare
Tomorrow9
reviewed
Jul 10, 2024
keirazhang
force-pushed
the
fix_centos10_gosc
branch
from
July 10, 2024 05:03
d64d3f2
to
c43fa7d
Compare
Tomorrow9
reviewed
Jul 15, 2024
Signed-off-by: Qi (Keira) Zhang <[email protected]>
Signed-off-by: Qi (Keira) Zhang <[email protected]>
Signed-off-by: Qi (Keira) Zhang <[email protected]>
Signed-off-by: Qi (Keira) Zhang <[email protected]>
Signed-off-by: Qi (Keira) Zhang <[email protected]>
Signed-off-by: Qi (Keira) Zhang <[email protected]>
Signed-off-by: Qi (Keira) Zhang <[email protected]>
Signed-off-by: Qi (Keira) Zhang <[email protected]>
Signed-off-by: Qi (Keira) Zhang <[email protected]>
Signed-off-by: Qi (Keira) Zhang <[email protected]>
Signed-off-by: Qi (Keira) Zhang <[email protected]>
Signed-off-by: Qi Zhang <[email protected]>
keirazhang
force-pushed
the
fix_centos10_gosc
branch
from
July 15, 2024 08:11
c43fa7d
to
40d76a7
Compare
Signed-off-by: Qi Zhang <[email protected]>
keirazhang
force-pushed
the
fix_centos10_gosc
branch
from
July 16, 2024 06:00
6818183
to
4a2bfae
Compare
Signed-off-by: Qi Zhang <[email protected]>
Signed-off-by: Qi Zhang <[email protected]>
Tomorrow9
reviewed
Jul 16, 2024
Signed-off-by: Qi Zhang <[email protected]>
Tomorrow9
approved these changes
Jul 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linux/guest_customization/gosc_support_matrix.yml
, these OS will follow RHEL's GOSC support matrix.linux/guest_customization/handle_gosc_known_issues.yml
. Currently 3 known issues were handled:/etc/sysconfig/network-scripts
, which will lead to GOSC failure on vSphere 8.0.x. In vSphere 8.0.3, an workaround fix was provided, which is to manually create this directory. Then GOSC scripts can create network config file under it.