Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenSUSE] ovt_verify_pkg_install is failed and undefined variable is reported in ovt_verify_pkg_install #590

Merged
merged 3 commits into from
Jun 14, 2024
Merged

[OpenSUSE] ovt_verify_pkg_install is failed and undefined variable is reported in ovt_verify_pkg_install #590

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6c962ef
fix ovt_verify_pkg_install issue for opensusu
ZouYuhua Jun 13, 2024
6ba74a3
fix undefined variable
ZouYuhua Jun 14, 2024
bb085c8
change code as codereview
ZouYuhua Jun 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions linux/open_vm_tools/uninstall_ovt.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
#
# Uninstall open-vm-tools packages
- name: "Uninstall packages {{ ovt_packages }}"
ansible.builtin.command: "{{ package_uninstall_cmd }} {{' '.join(ovt_packages) }}"
ansible.builtin.command: "{{ package_uninstall_cmd }} {{ ' '.join(ovt_packages) }}"
register: ovt_uninstall_result
ignore_errors: true
delegate_to: "{{ vm_guest_ip }}"
Expand All @@ -24,7 +24,7 @@
- ovt_uninstall_result.stdout
- ovt_uninstall_result.rc is defined
- ovt_uninstall_result.rc | int == 0
fail_msg: "Failed to uninstall open-vm-tools by executing command: {{ ' '.join(ovt_uninstall_result.cmd) }}"
fail_msg: "Failed to uninstall open-vm-tools by executing command: {{ package_uninstall_cmd }} {{ ' '.join(ovt_packages) }}"

- name: "Reboot VM to make changes take effect"
include_tasks: ../utils/reboot.yml
Expand Down
4 changes: 2 additions & 2 deletions linux/setup/reconfig_existing_guest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@
package_list: ["gawk", "python3-rpm", "tar"]
package_state: "present"

- name: "Reconfigure SLED"
when: guest_os_ansible_distribution == "SLED"
- name: "Reconfigure {{ guest_os_ansible_distribution }}"
when: guest_os_family == "Suse"
block:
- name: "Check 'PackageKit' service state"
include_tasks: ../utils/get_service_info.yml
Expand Down