Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Linux] Support to test installing open-vm-tools from source on FreeBSD #582

Merged
merged 4 commits into from
May 24, 2024

Conversation

keirazhang
Copy link
Contributor

Installing open-vm-tools from source works well on FreeBSD 13.x. But on FreeBSD 14.x, it has 2 compiling errors about vmmemctl and vmblock.

FreeBSD 14 has provided two patches files against vmmemctl and vmblock compiling error, but not upstream them yet.

/usr/ports/emulators/open-vm-tools/files/patch-modules_freebsd_vmmemctl_os.c
/usr/ports/emulators/open-vm-tools/files/patch-modules_freebsd_vmblock_vfsops.c

We already have an internal PR to track upstreaming FreeBSD patches. To ensure our tests go smoothly, our test case will firstly patch the two files before building open-vm-tools source on FreeBSD 14. After the two patch files are upstreamed, we can then remove the patch from our test case.

FreeBSD 13.3 and 14.1 tests passed:

+----------------------------------------------------------+
| GuestInfo Detailed Data   | architecture='X86'           |
|                           | bitness='32'                 |
|                           | distroName='FreeBSD'         |
|                           | familyName='FreeBSD'         |
|                           | kernelVersion='13.3-RELEASE' |
+----------------------------------------------------------+


Test Results (Total: 16, Passed: 8, Skipped: 8, Elapsed Time: 00:59:56)
+--------------------------------------------------------------------------+
| ID | Name                                 |   Status         | Exec Time |
+--------------------------------------------------------------------------+
| 01 | deploy_vm_bios_paravirtual_vmxnet3   |   Passed         | 00:33:52  |
| 02 | check_inbox_driver                   |   Passed         | 00:01:03  |
| 03 | ovt_verify_src_install               |   Passed         | 00:16:10  |
| 04 | ovt_verify_status                    | * Not Applicable | 00:00:25  |
| 05 | vgauth_check_service                 | * Not Supported  | 00:00:32  |
| 06 | check_ip_address                     |   Passed         | 00:00:33  |
| 07 | check_os_fullname                    |   Passed         | 00:00:44  |
| 08 | stat_balloon                         |   Passed         | 00:00:31  |
| 09 | stat_hosttime                        |   Passed         | 00:00:33  |
| 10 | device_list                          |   Passed         | 00:02:22  |
| 11 | check_quiesce_snapshot_custom_script | * Not Supported  | 00:00:23  |
| 12 | gosc_perl_dhcp                       | * Not Supported  | 00:00:32  |
| 13 | gosc_perl_staticip                   | * Not Supported  | 00:00:28  |
| 14 | gosc_cloudinit_dhcp                  | * Not Supported  | 00:00:32  |
| 15 | gosc_cloudinit_staticip              | * Not Supported  | 00:00:28  |
| 16 | ovt_verify_pkg_uninstall             | * Not Applicable | 00:00:29  |
+--------------------------------------------------------------------------+
+----------------------------------------------------------+
| GuestInfo Detailed Data   | architecture='X86'           |
|                           | bitness='64'                 |
|                           | distroName='FreeBSD'         |
|                           | familyName='FreeBSD'         |
|                           | kernelVersion='13.3-RELEASE' |
+----------------------------------------------------------+


Test Results (Total: 16, Passed: 8, Skipped: 8, Elapsed Time: 01:35:51)
+--------------------------------------------------------------------------+
| ID | Name                                 |   Status         | Exec Time |
+--------------------------------------------------------------------------+
| 01 | deploy_vm_efi_paravirtual_vmxnet3    |   Passed         | 01:08:46  |
| 02 | check_inbox_driver                   |   Passed         | 00:01:06  |
| 03 | ovt_verify_src_install               |   Passed         | 00:14:58  |
| 04 | ovt_verify_status                    | * Not Applicable | 00:00:39  |
| 05 | vgauth_check_service                 | * Not Supported  | 00:00:39  |
| 06 | check_ip_address                     |   Passed         | 00:00:44  |
| 07 | check_os_fullname                    |   Passed         | 00:01:02  |
| 08 | stat_balloon                         |   Passed         | 00:00:44  |
| 09 | stat_hosttime                        |   Passed         | 00:00:44  |
| 10 | device_list                          |   Passed         | 00:02:18  |
| 11 | check_quiesce_snapshot_custom_script | * Not Supported  | 00:00:36  |
| 12 | gosc_perl_dhcp                       | * Not Supported  | 00:00:42  |
| 13 | gosc_perl_staticip                   | * Not Supported  | 00:00:39  |
| 14 | gosc_cloudinit_dhcp                  | * Not Supported  | 00:00:37  |
| 15 | gosc_cloudinit_staticip              | * Not Supported  | 00:00:42  |
| 16 | ovt_verify_pkg_uninstall             | * Not Applicable | 00:00:34  |
+--------------------------------------------------------------------------+
+--------------------------------------------------------+
| GuestInfo Detailed Data   | architecture='X86'         |
|                           | bitness='32'               |
|                           | distroName='FreeBSD'       |
|                           | familyName='FreeBSD'       |
|                           | kernelVersion='14.1-BETA3' |
+--------------------------------------------------------+


Test Results (Total: 16, Passed: 8, Skipped: 8, Elapsed Time: 01:04:51)
+--------------------------------------------------------------------------+
| ID | Name                                 |   Status         | Exec Time |
+--------------------------------------------------------------------------+
| 01 | deploy_vm_bios_paravirtual_vmxnet3   |   Passed         | 00:36:37  |
| 02 | check_inbox_driver                   |   Passed         | 00:01:06  |
| 03 | ovt_verify_src_install               |   Passed         | 00:16:18  |
| 04 | ovt_verify_status                    | * Not Applicable | 00:00:32  |
| 05 | vgauth_check_service                 | * Not Supported  | 00:00:41  |
| 06 | check_ip_address                     |   Passed         | 00:00:43  |
| 07 | check_os_fullname                    |   Passed         | 00:00:55  |
| 08 | stat_balloon                         |   Passed         | 00:00:39  |
| 09 | stat_hosttime                        |   Passed         | 00:00:42  |
| 10 | device_list                          |   Passed         | 00:02:23  |
| 11 | check_quiesce_snapshot_custom_script | * Not Supported  | 00:00:36  |
| 12 | gosc_perl_dhcp                       | * Not Supported  | 00:00:39  |
| 13 | gosc_perl_staticip                   | * Not Supported  | 00:00:37  |
| 14 | gosc_cloudinit_dhcp                  | * Not Supported  | 00:00:39  |
| 15 | gosc_cloudinit_staticip              | * Not Supported  | 00:00:42  |
| 16 | ovt_verify_pkg_uninstall             | * Not Applicable | 00:00:39  |
+--------------------------------------------------------------------------+
+--------------------------------------------------------+
| GuestInfo Detailed Data   | architecture='X86'         |
|                           | bitness='64'               |
|                           | distroName='FreeBSD'       |
|                           | familyName='FreeBSD'       |
|                           | kernelVersion='14.1-BETA3' |
+--------------------------------------------------------+


Test Results (Total: 16, Passed: 8, Skipped: 8, Elapsed Time: 01:16:22)
+--------------------------------------------------------------------------+
| ID | Name                                 |   Status         | Exec Time |
+--------------------------------------------------------------------------+
| 01 | deploy_vm_efi_paravirtual_vmxnet3    |   Passed         | 00:48:51  |
| 02 | check_inbox_driver                   |   Passed         | 00:01:06  |
| 03 | ovt_verify_src_install               |   Passed         | 00:14:53  |
| 04 | ovt_verify_status                    | * Not Applicable | 00:00:45  |
| 05 | vgauth_check_service                 | * Not Supported  | 00:00:39  |
| 06 | check_ip_address                     |   Passed         | 00:00:44  |
| 07 | check_os_fullname                    |   Passed         | 00:01:06  |
| 08 | stat_balloon                         |   Passed         | 00:00:37  |
| 09 | stat_hosttime                        |   Passed         | 00:00:45  |
| 10 | device_list                          |   Passed         | 00:02:32  |
| 11 | check_quiesce_snapshot_custom_script | * Not Supported  | 00:00:44  |
| 12 | gosc_perl_dhcp                       | * Not Supported  | 00:00:38  |
| 13 | gosc_perl_staticip                   | * Not Supported  | 00:00:43  |
| 14 | gosc_cloudinit_dhcp                  | * Not Supported  | 00:00:39  |
| 15 | gosc_cloudinit_staticip              | * Not Supported  | 00:00:39  |
| 16 | ovt_verify_pkg_uninstall             | * Not Applicable | 00:00:37  |
+--------------------------------------------------------------------------+

@keirazhang keirazhang added this to the 3.2 milestone May 24, 2024
@keirazhang keirazhang requested a review from Tomorrow9 May 24, 2024 03:20
Copy link
Member

@Tomorrow9 Tomorrow9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@keirazhang keirazhang merged commit 15df869 into vmware:main May 24, 2024
@keirazhang keirazhang deleted the freebsd_ovt_src_install branch June 24, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants