Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Linux] Split pre and post tasks out from open-vm-tools installation #569

Merged
merged 3 commits into from
Apr 9, 2024

Conversation

keirazhang
Copy link
Contributor

There are some common tasks can be used for verifying OVT package install and source install, so this change moved out those common tasks from linux/open_vm_tools/ovt_verify_pkg_install.yml.

  1. Split ovt_verify_pkg_install.yml to pre_ovt_install.yml, install_ovt_from_package.yml, and `post_ovt_install.yml'
  2. pre_ovt_install.yml contains all tasks before installing open-vm-tools from package, including uninstalling existing open-vm-tools and setting up package repositories.
  3. install_ovt_from_package.yml contains tasks to install open-vm-tools packages and checking the installation result.
  4. post_ovt_install.yml contains tasks after open-vm-tools installation, like ejecting CDROMS, updating VMTools version and build, updating VM guest info, resetting base snapshot, etc.

@keirazhang keirazhang added this to the 3.2 milestone Apr 7, 2024
@keirazhang keirazhang requested a review from Tomorrow9 April 7, 2024 12:32
123lzxm
123lzxm previously approved these changes Apr 8, 2024
Copy link
Collaborator

@123lzxm 123lzxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

linux/open_vm_tools/install_ovt_from_package.yml Outdated Show resolved Hide resolved
linux/open_vm_tools/pre_ovt_install.yml Outdated Show resolved Hide resolved
linux/open_vm_tools/pre_ovt_install.yml Outdated Show resolved Hide resolved
Signed-off-by: Qi Zhang <[email protected]>
@keirazhang
Copy link
Contributor Author

Above comments were addressed. Thanks!

Copy link
Member

@Tomorrow9 Tomorrow9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@keirazhang keirazhang merged commit c03aaaa into vmware:main Apr 9, 2024
@keirazhang keirazhang deleted the split_ovt_pkg_install branch June 24, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants