-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract text from screenshot at test failure and errors from VM logs #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keirazhang
force-pushed
the
add_extractor
branch
from
January 4, 2024 12:05
b6e0bc3
to
93b7db0
Compare
The extractor.py can extract
|
123lzxm
reviewed
Jan 10, 2024
keirazhang
force-pushed
the
add_extractor
branch
from
January 15, 2024 05:14
ed4250f
to
7d13503
Compare
Tomorrow9
reviewed
Jan 15, 2024
keirazhang
force-pushed
the
add_extractor
branch
3 times, most recently
from
January 16, 2024 06:31
53ed5bb
to
5b65adb
Compare
Tomorrow9
reviewed
Jan 17, 2024
keirazhang
force-pushed
the
add_extractor
branch
from
January 17, 2024 03:53
32449c4
to
d5b3d37
Compare
Tomorrow9
reviewed
Jan 17, 2024
Tomorrow9
previously approved these changes
Jan 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Tomorrow9
reviewed
Jan 19, 2024
Signed-off-by: Qi Zhang <[email protected]> Signed-off-by: Qi Zhang <[email protected]>
Signed-off-by: Qi Zhang <[email protected]>
Signed-off-by: Qi Zhang <[email protected]>
Signed-off-by: Qi Zhang <[email protected]>
Signed-off-by: Qi Zhang <[email protected]>
…file Signed-off-by: Qi Zhang <[email protected]>
Signed-off-by: Qi Zhang <[email protected]>
…_log.yml Signed-off-by: Qi Zhang <[email protected]>
Signed-off-by: Qi Zhang <[email protected]>
Signed-off-by: Qi Zhang <[email protected]>
Signed-off-by: Qi Zhang <[email protected]>
Signed-off-by: Qi Zhang <[email protected]>
Signed-off-by: Qi Zhang <[email protected]>
Signed-off-by: Qi Zhang <[email protected]>
keirazhang
force-pushed
the
add_extractor
branch
from
January 19, 2024 07:20
18f1ab2
to
1fc1ba9
Compare
Tomorrow9
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix include:
tools/extractor.py
to extract text from screenshot and extract errors from VM's log file.fail_message
to append errors into failed_tasks.log