Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows] Fix test case 'gosc_sanity_dhcp' failure #526

Merged
merged 2 commits into from
Dec 28, 2023
Merged

[Windows] Fix test case 'gosc_sanity_dhcp' failure #526

merged 2 commits into from
Dec 28, 2023

Conversation

Tomorrow9
Copy link
Member

  1. always update host inventory after GOSC even DHCP IP is not changed.
  2. save back Administrator user password after GOSC test cases.

keirazhang
keirazhang approved these changes Dec 25, 2023
View reviewed changes
Copy link
Contributor

@keirazhang keirazhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

123lzxm
123lzxm approved these changes Dec 25, 2023
View reviewed changes
Copy link
Collaborator

@123lzxm 123lzxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@keirazhang keirazhang merged commit e1b32f1 into vmware:main Dec 28, 2023
@keirazhang keirazhang added this to the 3.1 milestone Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@123lzxm 123lzxm 123lzxm approved these changes

@keirazhang keirazhang keirazhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.
3 participants
@Tomorrow9 @keirazhang @123lzxm