Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows] Fix variables undefined error during deploying VM #459

Merged
merged 3 commits into from
Apr 14, 2023
Merged

[Windows] Fix variables undefined error during deploying VM #459

merged 3 commits into from
Apr 14, 2023

Conversation

123lzxm
Copy link
Collaborator

@123lzxm 123lzxm commented Apr 14, 2023

  1. Getting the guest OS build number before enabling VBS
  2. Do not add key provider when key provider type is not defined.

123lzxm added 2 commits April 14, 2023 09:56
@123lzxm
get the guest info during deploy vm
0b037d7 
Signed-off-by: Yanan Shen <[email protected]>
@123lzxm
remove test code
e1fe5d9 
Signed-off-by: Yanan Shen <[email protected]>
@123lzxm 123lzxm added this to the v2.3 milestone Apr 14, 2023
@123lzxm
address comments
a116c8d 
Signed-off-by: Yanan Shen <[email protected]>
keirazhang
keirazhang approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@keirazhang keirazhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@123lzxm 123lzxm merged commit 0adca60 into vmware:main Apr 14, 2023
@123lzxm 123lzxm deleted the fix-deploy-vbs branch June 13, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keirazhang keirazhang keirazhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.3
Development

Successfully merging this pull request may close these issues.
2 participants
@123lzxm @keirazhang