Support autoinstall for ubuntu 23.04 desktop

[ZouYuhua]

Task:
Support autoinstall for ubuntu desktop 23.04

Test results:

1. Pass for ubuntu 23.04 desktop with bios/efi:

2. Pass for ubuntu 23.04 live server

3. Pass for ubuntu 22.04 desktop

4. Pass for ubuntu 22.04 live server

[keirazhang]

linux/deploy_vm/eject_del_unattend_install_iso.yml and linux/deploy_vm/collect_vm_logs.yml shall also be updated.

[ZouYuhua]

linux/deploy_vm/eject_del_unattend_install_iso.yml and linux/deploy_vm/collect_vm_logs.yml shall also be updated.

Thanks. Change it.

[ZouYuhua]

Hit issue for the full testing after rebase from upstream:

2023-04-13 06:03:56,013 | TASK [1_deploy_vm][Check vm_primary_nic_mac is set for VM 'test_vm_1'] 
task path: /home/worker/workspace/Ansible_Ubuntu_23.04_Desktop_ISO_80GA_NVME_E1000E_EFI/ansible-vsphere-gos-validation/common/vm_get_ip.yml:10
fatal: [localhost]: FAILED! => {
    "assertion": "vm_primary_nic_mac",
    "changed": false,
    "evaluated_to": false,
    "msg": "Parameter 'vm_primary_nic_mac' must be set for getting VM's guest IPv4 address."
}
error message:
Parameter 'vm_primary_nic_mac' must be set for getting VM's guest IPv4 address.

I am working on the fix. Thanks

[ZouYuhua]

Hit issue for the full testing after rebase from upstream:

2023-04-13 06:03:56,013 | TASK [1_deploy_vm][Check vm_primary_nic_mac is set for VM 'test_vm_1'] 
task path: /home/worker/workspace/Ansible_Ubuntu_23.04_Desktop_ISO_80GA_NVME_E1000E_EFI/ansible-vsphere-gos-validation/common/vm_get_ip.yml:10
fatal: [localhost]: FAILED! => {
    "assertion": "vm_primary_nic_mac",
    "changed": false,
    "evaluated_to": false,
    "msg": "Parameter 'vm_primary_nic_mac' must be set for getting VM's guest IPv4 address."
}
error message:
Parameter 'vm_primary_nic_mac' must be set for getting VM's guest IPv4 address.

The module community.vmware.vmware_guest_network doesn't get the mac address:

TASK [Set fact of VM network adapters info] ************************************
task path: /home/worker/workspace/Ansible_Ubuntu_23.04_Desktop_ISO_MAIN_SATA_VMXNET3_EFI/ansible-vsphere-gos-validation/common/vm_get_network_facts.yml:21
ok: [localhost] => {
    "ansible_facts": {
        "vm_network_adapters": {
            "0": {
                "allow_guest_ctl": true,
                "connected": false,
                "device_type": "vmxnet3",
                "label": "Network adapter 1",
                "mac_addr": null,
                "mac_address": null,
                "name": "VM Network",
                "network_name": "VM Network",
                "start_connected": true,
                "switch": "vSwitch0",
                "unit_number": 7,
                "vlan_id": 0,
                "wake_onlan": true
            }
        }
    },
    "changed": false
}

TASK [Print the VM network adapters info] **************************************
task path: /home/worker/workspace/Ansible_Ubuntu_23.04_Desktop_ISO_MAIN_SATA_VMXNET3_EFI/ansible-vsphere-gos-validation/common/vm_get_network_facts.yml:25
ok: [localhost] => {
    "vm_network_adapters": {
        "0": {
            "allow_guest_ctl": true,
            "connected": false,
            "device_type": "vmxnet3",
            "label": "Network adapter 1",
            "mac_addr": null,
            "mac_address": null,
            "name": "VM Network",
            "network_name": "VM Network",
            "start_connected": true,
            "switch": "vSwitch0",
            "unit_number": 7,
            "vlan_id": 0,
            "wake_onlan": true
        }
    }
}

TASK [Set fact of VM's primary network adapter MAC address] ********************
task path: /home/worker/workspace/Ansible_Ubuntu_23.04_Desktop_ISO_MAIN_SATA_VMXNET3_EFI/ansible-vsphere-gos-validation/common/vm_get_vm_info.yml:30
ok: [localhost] => {
    "ansible_facts": {
        "vm_primary_nic_mac": ""
    },
    "changed": false
}

[ZouYuhua]

The module community.vmware.vmware_guest_network doesn't get the mac address

Apply the workaround for the issue:
run vm_get_network_facts.yml to get the mac address before the update_inventory.yml

[ZouYuhua]

Hi Qi,
Is it OK for the workaround to the issue "Parameter 'vm_primary_nic_mac' must be set for getting VM's guest IPv4 address." Thanks

[ZouYuhua]

The testing is on-going after all the changes. Thanks

[keirazhang]

LGTM. Thanks!