Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

save the powershell result before using it in when condition #434

Merged
merged 1 commit into from
Mar 16, 2023
Merged

save the powershell result before using it in when condition #434

merged 1 commit into from
Mar 16, 2023

Conversation

123lzxm
Copy link
Collaborator

@123lzxm 123lzxm commented Mar 15, 2023

No description provided.

keirazhang
keirazhang previously approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@keirazhang keirazhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@vmwclabot
Copy link
Member

@123lzxm, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot
Copy link
Member

@123lzxm, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Tomorrow9
Tomorrow9 previously approved these changes Mar 15, 2023
View reviewed changes
@123lzxm 123lzxm merged commit de67537 into vmware:main Mar 16, 2023
@123lzxm 123lzxm deleted the fix-save-var branch March 16, 2023 01:43
123lzxm added a commit to 123lzxm/ansible-vsphere-gos-validation that referenced this pull request Mar 16, 2023
@123lzxm
save the powershell result before using it in when condition (vmware#434
a26b65a 
)

Signed-off-by: Yanan Shen <[email protected]>
123lzxm added a commit to 123lzxm/ansible-vsphere-gos-validation that referenced this pull request Mar 16, 2023
@123lzxm
save the powershell result before using it in when condition (vmware#434
d336edd 
)

Signed-off-by: Yanan Shen <[email protected]>
@keirazhang keirazhang added this to the v2.3 milestone Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tomorrow9 Tomorrow9 Tomorrow9 approved these changes

@keirazhang keirazhang keirazhang left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.3
Development

Successfully merging this pull request may close these issues.
4 participants
@123lzxm @vmwclabot @keirazhang @Tomorrow9