Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 370 redirecting types and deprecation warnings #433

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

yanhuih2022
Copy link
Collaborator

@yanhuih2022 yanhuih2022 commented Mar 15, 2023

[ansible-vsphere-gos-validation] Fix redirecting types and deprecation warnings

redirecting (type: action) ansible.builtin.win_copy to ansible.windows.win_copy
redirecting (type: modules) ansible.builtin.win_stat to ansible.windows.win_stat
redirecting (type: modules) ansible.builtin.win_file to ansible.windows.win_file
redirecting (type: callback) ansible.builtin.timer to ansible.posix.timer (Cannot find)
redirecting (type: modules) ansible.builtin.setup to ansible.windows.setup
redirecting (type: filter) ansible.netcommon.hwaddr to ansible.utils.hwaddr
redirecting (type: modules) ansible.builtin.vmware_guest to community.vmware.vmware_guest

There is one still exists.
redirecting (type: callback) ansible.builtin.timer to ansible.posix.timer

Verified with Qi, and make sure it is a callback and isn't a module. It can be ignored.

Copy link
Contributor

@keirazhang keirazhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also test your changes with Linux guest OS

common/get_system_info.yml Outdated Show resolved Hide resolved
common/get_system_info.yml Outdated Show resolved Hide resolved
common/vm_test_nic.yml Outdated Show resolved Hide resolved
@yanhuih2022
Copy link
Collaborator Author

OK, thanks Qi!

@yanhuih2022
Copy link
Collaborator Author

Passed in Linux Guest OS.

@Tomorrow9
Copy link
Member

We'd better exclude internal used ticket number in this external merge request in title Fix GOSV-2299 redirecting types and deprecation warnings, thanks.

@keirazhang keirazhang changed the title Fix GOSV-2299 redirecting types and deprecation warnings Fix 370 redirecting types and deprecation warnings Mar 16, 2023
keirazhang

This comment was marked as outdated.

Copy link
Contributor

@keirazhang keirazhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found below redirecting:

Read vars_file '{{ testing_vars_file | default('../../vars/test.yml') }}'
[DEPRECATION WARNING]: Use 'ansible.utils.hwaddr' module instead. This feature 
will be removed from ansible.netcommon in a release after 2024-01-01. 
Deprecation warnings can be disabled by setting deprecation_warnings=False in 
ansible.cfg.
redirecting (type: filter) ansible.netcommon.hwaddr to ansible.utils.hwaddr
redirecting (type: modules) ansible.builtin.zypper_repository to community.general.zypper_repository
redirecting (type: modules) ansible.builtin.archive to community.general.archive
redirecting (type: modules) ansible.builtin.iso_extract to community.general.iso_extract

Signed-off-by: “yanhuih2022” <“[email protected]”>
@keirazhang keirazhang merged commit 11af78a into vmware:main Mar 30, 2023
@yanhuih2022 yanhuih2022 deleted the fix_GOSV-2299 branch April 10, 2023 10:16
@keirazhang keirazhang added this to the v2.3 milestone Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants