-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the issue that PVRDMA client VM has same IP address with server VM #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keirazhang
force-pushed
the
fix_rhel7_pvrdma
branch
3 times, most recently
from
March 2, 2023 03:40
369c0ad
to
8db9ab1
Compare
keirazhang
changed the title
Fix the issue that PVRDMA client VM has same IP address with server VM
[WIP]Fix the issue that PVRDMA client VM has same IP address with server VM
Mar 6, 2023
keirazhang
force-pushed
the
fix_rhel7_pvrdma
branch
3 times, most recently
from
March 7, 2023 15:04
e90c7e1
to
3a45963
Compare
keirazhang
changed the title
[WIP]Fix the issue that PVRDMA client VM has same IP address with server VM
Fix the issue that PVRDMA client VM has same IP address with server VM
Mar 8, 2023
Signed-off-by: Qi Zhang <[email protected]>
keirazhang
force-pushed
the
fix_rhel7_pvrdma
branch
from
March 8, 2023 06:22
15d1599
to
18fda41
Compare
Signed-off-by: Qi Zhang <[email protected]>
Signed-off-by: Qi Zhang <[email protected]>
Tomorrow9
reviewed
Mar 14, 2023
Signed-off-by: Qi Zhang <[email protected]>
123lzxm
reviewed
Mar 14, 2023
Signed-off-by: Qi Zhang <[email protected]>
Signed-off-by: Qi Zhang <[email protected]>
Tomorrow9
approved these changes
Mar 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the instant cloned client VM reset, its IP address may be same with server VM because of the MAC address hasn't change. Usually after a few seconds, the MAC address will be changed to same with VM's settings and then its IP address would also be changed.
This fix will remove MAC or UUID from network adapter 1's network config file before instant clone, and then refresh client VM's IP address till it has different IP with server VM. After that, the testing can go ahead.