Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows] add check driver version in test case check_inbox_driver #422

Merged
merged 4 commits into from
Feb 9, 2023
Merged

[Windows] add check driver version in test case check_inbox_driver #422

merged 4 commits into from
Feb 9, 2023

Conversation

Tomorrow9
Copy link
Member

@Tomorrow9 Tomorrow9 commented Feb 8, 2023 •
edited
Loading

Signed-off-by: Diane Wang [email protected]
Fixes #345

@Tomorrow9 Tomorrow9 added this to the v2.3 milestone Feb 8, 2023
@Tomorrow9
Copy link
Member Author 

VM information:
+-----------------------------------------------------------------------------+
| Name                      | test_vm                                         |
+-----------------------------------------------------------------------------+
| IP                        |                                   |
+-----------------------------------------------------------------------------+
| Guest OS Distribution     | Microsoft Windows 11 Enterprise Insider Preview |
|                           | 10.0.25276.0 64-bit                             |
+-----------------------------------------------------------------------------+
| Hardware Version          | vmx-20                                          |
+-----------------------------------------------------------------------------+
| VMTools Version           |                                                 |
+-----------------------------------------------------------------------------+
| Config Guest Id           | windows11_64Guest                               |
+-----------------------------------------------------------------------------+
| GuestInfo Guest Id        |                                                 |
+-----------------------------------------------------------------------------+
| GuestInfo Guest Full Name |                                                 |
+-----------------------------------------------------------------------------+
| GuestInfo Guest Family    |                                                 |
+-----------------------------------------------------------------------------+
| GuestInfo Detailed Data   |                                                 |
+-----------------------------------------------------------------------------+

Test Results (Total: 2, Passed: 2, Elapsed Time: 00:28:38)
+--------------------------------------------------------+
| Name                              | Status | Exec Time |
+--------------------------------------------------------+
| deploy_vm_efi_paravirtual_vmxnet3 | Passed | 00:19:09  |
| check_inbox_driver                | Passed | 00:09:06  |
+--------------------------------------------------------+

@Tomorrow9 Tomorrow9 requested a review from 123lzxm February 8, 2023 04:15
123lzxm
123lzxm previously approved these changes Feb 8, 2023
View reviewed changes
Copy link
Collaborator

@123lzxm 123lzxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

keirazhang
keirazhang reviewed Feb 8, 2023
View reviewed changes
docs/TESTCASE_DEV_GUIDE.md Outdated Show resolved Hide resolved
docs/TESTCASE_DEV_GUIDE.md Outdated Show resolved Hide resolved
docs/TESTCASE_DEV_GUIDE.md Outdated Show resolved Hide resolved
docs/TESTCASE_DEV_GUIDE.md Outdated Show resolved Hide resolved
@Tomorrow9
address comments
a5e7ba8 
Signed-off-by: Diane Wang <[email protected]>
@Tomorrow9
address comments
1876d82 
Signed-off-by: Diane Wang <[email protected]>
keirazhang
keirazhang approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@keirazhang keirazhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@Tomorrow9 Tomorrow9 merged commit 0add65b into vmware:main Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keirazhang keirazhang keirazhang approved these changes

@123lzxm 123lzxm 123lzxm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.3
Development

Successfully merging this pull request may close these issues.

[New Feature][Windows] improve test case check_inbox_driver
3 participants
@Tomorrow9 @keirazhang @123lzxm