-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Linux] Improve check_os_fullname test case to check guest id and guest family #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keirazhang
changed the title
[Linux] Improved check_os_fullname test case to check guest id and guest family
[Linux] Improve check_os_fullname test case to check guest id and guest family
Feb 6, 2023
Signed-off-by: Qi Zhang <[email protected]>
Signed-off-by: Qi Zhang <[email protected]>
Signed-off-by: Qi Zhang <[email protected]>
Signed-off-by: Qi Zhang <[email protected]>
Signed-off-by: Qi Zhang <[email protected]>
Signed-off-by: Qi Zhang <[email protected]>
Signed-off-by: Qi Zhang <[email protected]>
Signed-off-by: Qi Zhang <[email protected]>
Signed-off-by: Qi Zhang <[email protected]>
Signed-off-by: Qi Zhang <[email protected]>
Signed-off-by: Qi Zhang <[email protected]>
Signed-off-by: Qi Zhang <[email protected]>
Signed-off-by: Qi Zhang <[email protected]>
keirazhang
force-pushed
the
fix_os_fullname
branch
from
February 6, 2023 10:13
97b30cb
to
c9041f1
Compare
123lzxm
reviewed
Feb 6, 2023
123lzxm
reviewed
Feb 6, 2023
Signed-off-by: Qi Zhang <[email protected]>
keirazhang
force-pushed
the
fix_os_fullname
branch
from
February 7, 2023 03:19
b910842
to
d7a1bac
Compare
Tomorrow9
reviewed
Feb 7, 2023
Signed-off-by: Qi Zhang <[email protected]>
keirazhang
force-pushed
the
fix_os_fullname
branch
from
February 7, 2023 04:08
d7a1bac
to
728c44e
Compare
Signed-off-by: Qi Zhang <[email protected]>
keirazhang
force-pushed
the
fix_os_fullname
branch
from
February 8, 2023 05:47
6202743
to
caec538
Compare
Tomorrow9
approved these changes
Feb 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The improvement in this change