Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows]wsl for windows server #412

Merged
merged 4 commits into from
Feb 15, 2023
Merged

[Windows]wsl for windows server #412

merged 4 commits into from
Feb 15, 2023

Conversation

123lzxm
Copy link
Collaborator

@123lzxm 123lzxm commented Jan 16, 2023

Signed-off-by: Yanan Shen [email protected]

@123lzxm 123lzxm added this to the v2.3 milestone Jan 16, 2023
@123lzxm 123lzxm changed the title wsl for windows server [Windows]wsl for windows server Feb 8, 2023
@123lzxm 123lzxm force-pushed the wsl-server branch 2 times, most recently from d03944e to becdb27 Compare February 13, 2023 04:54
@123lzxm
Copy link
Collaborator Author

123lzxm commented Feb 13, 2023 

+----------------------------------------------------------------------+
| Name                      | wsl_win_serve_2022_ga                    |
+----------------------------------------------------------------------+
| IP                        |                       |
+----------------------------------------------------------------------+
| Guest OS Distribution     | Microsoft Windows Server 2022 Datacenter |
|                           | 10.0.20348.0 64-bit                      |
+----------------------------------------------------------------------+
| Hardware Version          | vmx-20                                   |
+----------------------------------------------------------------------+
| VMTools Version           |                                          |
+----------------------------------------------------------------------+
| Config Guest Id           | windows2019srvNext_64Guest               |
+----------------------------------------------------------------------+
| GuestInfo Guest Id        |                                          |
+----------------------------------------------------------------------+
| GuestInfo Guest Full Name |                                          |
+----------------------------------------------------------------------+
| GuestInfo Guest Family    |                                          |
+----------------------------------------------------------------------+
| GuestInfo Detailed Data   |                                          |
+----------------------------------------------------------------------+
+------------------------------------------------------+
| Name                         |   Status  | Exec Time |
+------------------------------------------------------+
| deploy_vm                    | * Skipped | 00:00:00  |
| wsl_distro_install_uninstall |   Passed  | 00:09:35  |
+------------------------------------------------------+

@123lzxm 123lzxm requested review from Tomorrow9 and keirazhang and removed request for keirazhang February 13, 2023 09:31
@123lzxm
address review comments
e5962e0 
Signed-off-by: Yanan Shen <[email protected]>
@123lzxm
fix comments
30975a4 
Signed-off-by: Yanan Shen <[email protected]>
Tomorrow9
Tomorrow9 approved these changes Feb 15, 2023
View reviewed changes
Copy link
Member

@Tomorrow9 Tomorrow9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@123lzxm 123lzxm merged commit a482f56 into vmware:main Feb 15, 2023
@123lzxm 123lzxm deleted the wsl-server branch February 15, 2023 02:08
@123lzxm 123lzxm mentioned this pull request Feb 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keirazhang keirazhang keirazhang left review comments

@Tomorrow9 Tomorrow9 Tomorrow9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.3
Development

Successfully merging this pull request may close these issues.
3 participants
@123lzxm @keirazhang @Tomorrow9