Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add maintenance history for backupRepository CRs #8532

Merged

Conversation

Lyndon-Li
Copy link
Contributor

Fix issue #7810, add maintenance history for backupRepository CRs

@Lyndon-Li Lyndon-Li force-pushed the isolate-message-in-backup-repo branch from 8fa1215 to 3b2c50b Compare December 19, 2024 08:20
@@ -88,8 +88,8 @@ spec:
description: BackupRepositoryStatus is the current status of a BackupRepository.
properties:
lastMaintenanceTime:
description: LastMaintenanceTime is the last time maintenance was
run.
description: LastMaintenanceTime is the last time repo maintenance
Copy link
Contributor Author

@Lyndon-Li Lyndon-Li Dec 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Breaking change]: LastMaintenanceTime should be used to record the completion time of a successful maintenance.
Previously, it is used to record the start time of a successful maintenance, which is not reasonable. E.g., I run a maintenance which takes more than 1 hour; since the default frequency for quick maintenance is 1 hour, the next maintenance will be launched immediately after the first one completes, but actually it is a wasting one as data has just been maintained.
Previously, the description in the CRD is ambiguous, it could mean the completion time or start time.

So in this PR, both the description and the value set to LastMaintenanceTime as changed.

@Lyndon-Li Lyndon-Li marked this pull request as ready for review December 19, 2024 08:35
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.

Project coverage is 59.20%. Comparing base (010fd1c) to head (92390e9).
Report is 24 commits behind head on main.

Files with missing lines Patch % Lines
pkg/controller/backup_repository_controller.go 94.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8532      +/-   ##
==========================================
+ Coverage   59.18%   59.20%   +0.01%     
==========================================
  Files         369      369              
  Lines       39329    39427      +98     
==========================================
+ Hits        23276    23341      +65     
- Misses      14585    14617      +32     
- Partials     1468     1469       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lyndon-Li Lyndon-Li force-pushed the isolate-message-in-backup-repo branch from 6c49528 to 882875f Compare December 23, 2024 07:22
@Lyndon-Li Lyndon-Li force-pushed the isolate-message-in-backup-repo branch from 882875f to 77f1141 Compare December 23, 2024 07:24
@Lyndon-Li Lyndon-Li requested review from kaovilai and reasonerjt and removed request for kaovilai December 23, 2024 08:41
@Lyndon-Li Lyndon-Li added the Breaking change Impacts backwards compatibility label Dec 23, 2024
@reasonerjt reasonerjt merged commit eeee79e into vmware-tanzu:main Dec 23, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants