Use PVC to track the CSI snapshot in restore #7852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reasonerjt
added
the
kind/changelog-not-required
reasonerjt
requested review from
blackpiglet
and removed request for
shubham-pampattiwar
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-1.14 #7852 +/- ##
================================================
- Coverage 58.80% 58.79% -0.01%
================================================
Files 345 345
Lines 28759 28765 +6
================================================
+ Hits 16911 16913 +2
- Misses 10420 10423 +3
- Partials 1428 1429 +1 ☔ View full report in Codecov by Sentry. |
blackpiglet
approved these changes
Jun 4, 2024
This commit fixes vmware-tanzu#7849. It will use PVC instead of PV to track CSI snapshots to generate restore volume info metadata. So that in the case the PVC is not bound to PV the metadata can be populated correctly. Signed-off-by: Daniel Jiang <[email protected]>
ywk253100
approved these changes
Jun 4, 2024
|
For some reason, the DCO check is pending on the status I will temporarily remove it from the required checks. |
reasonerjt
merged commit 2136679
into
vmware-tanzu:release-1.14
195 of 197 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes #7849.
It will use PVC instead of PV to track CSI snapshots to generate restore volume info metadata. So that in the case the PVC is not bound to PV the metadata can be populated correctly.
Thank you for contributing to Velero!
Fixes #7849
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.