Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add E2E test for schedule backup creation principle #6097

Merged

Conversation

danfengliu
Copy link
Contributor

@danfengliu danfengliu commented Apr 9, 2023

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #5693

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@danfengliu danfengliu added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Apr 9, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #6097 (331b130) into main (bacec11) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #6097      +/-   ##
==========================================
- Coverage   41.32%   41.26%   -0.06%     
==========================================
  Files         251      251              
  Lines       23399    23399              
==========================================
- Hits         9669     9656      -13     
- Misses      12972    12984      +12     
- Partials      758      759       +1     

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danfengliu danfengliu marked this pull request as ready for review April 12, 2023 10:20
@github-actions github-actions bot requested review from blackpiglet and sseago April 12, 2023 10:20
blackpiglet
blackpiglet previously approved these changes Apr 12, 2023
@danfengliu danfengliu force-pushed the add-e2e-test-for-schedule-backup-creation branch from 331b130 to 504b1cb Compare April 12, 2023 10:31
@danfengliu danfengliu requested a review from blackpiglet April 12, 2023 11:19
@sseago sseago merged commit d298c6d into vmware-tanzu:main Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-e2e-tests kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
4 participants