Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pointer deference to string in error message #5485

Merged
merged 1 commit into from
Nov 4, 2022

Conversation

Ahmad-Faizan
Copy link
Contributor

Signed-off-by: Faizan Ahmad [email protected]

Thank you for contributing to Velero!

Please add a summary of your change

Fixed an error message in VolumeSnapshotContent

Does your change fix a particular issue?

No
Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@Ahmad-Faizan
Copy link
Contributor Author

/kind changelog-not-required

@github-actions github-actions bot added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Oct 25, 2022
@Ahmad-Faizan
Copy link
Contributor Author

This were the original logs generated by velero:

time="2022-10-25T00:11:30Z" level=error msg="Not find %!s(*string=0xc002343d10) from the vscMap" backup=velero/staging-daily-backup-20221025000014 logSource="pkg/controller/backup_controller.go:944"
time="2022-10-25T00:11:30Z" level=error msg="Not find %!s(*string=0xc002d600a0) from the vscMap" backup=velero/staging-daily-backup-20221025000014 logSource="pkg/controller/backup_controller.go:944"

@blackpiglet blackpiglet added kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes and removed kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes labels Oct 31, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #5485 (9d01432) into main (5f43361) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #5485   +/-   ##
=======================================
  Coverage   40.73%   40.73%           
=======================================
  Files         238      238           
  Lines       20561    20561           
=======================================
  Hits         8375     8375           
  Misses      11571    11571           
  Partials      615      615           
Impacted Files Coverage Δ
pkg/controller/backup_controller.go 55.23% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Lyndon-Li Lyndon-Li merged commit cc9d492 into vmware-tanzu:main Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants