-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade velero docker image to use go 1.18 #5459
Merged
Lyndon-Li
merged 4 commits into
vmware-tanzu:main
from
Lyndon-Li:velero-docker-image-go-1.18
Oct 19, 2022
Merged
Upgrade velero docker image to use go 1.18 #5459
Lyndon-Li
merged 4 commits into
vmware-tanzu:main
from
Lyndon-Li:velero-docker-image-go-1.18
Oct 19, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5459 +/- ##
==========================================
+ Coverage 40.52% 40.56% +0.04%
==========================================
Files 236 236
Lines 20482 20484 +2
==========================================
+ Hits 8300 8310 +10
+ Misses 11572 11565 -7
+ Partials 610 609 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Lyndon-Li
force-pushed
the
velero-docker-image-go-1.18
branch
from
October 18, 2022 12:06
94c4b04
to
dbc5c59
Compare
Lyndon-Li
added
the
kind/changelog-not-required
PR does not require a user changelog. Often for docs, website, or build changes
label
Oct 18, 2022
Signed-off-by: Lyndon-Li <[email protected]>
Lyndon-Li
force-pushed
the
velero-docker-image-go-1.18
branch
4 times, most recently
from
October 18, 2022 13:47
bcd9cb2
to
f17e59d
Compare
Signed-off-by: Lyndon-Li <[email protected]>
Lyndon-Li
force-pushed
the
velero-docker-image-go-1.18
branch
2 times, most recently
from
October 18, 2022 14:29
3e772fd
to
0b39fd6
Compare
Lyndon-Li
requested review from
blackpiglet,
ywk253100,
reasonerjt and
qiuming-best
October 18, 2022 14:35
Signed-off-by: Lyndon-Li <[email protected]>
Lyndon-Li
force-pushed
the
velero-docker-image-go-1.18
branch
from
October 18, 2022 14:41
0b39fd6
to
c92f06e
Compare
Lyndon-Li
removed
the
kind/changelog-not-required
PR does not require a user changelog. Often for docs, website, or build changes
label
Oct 18, 2022
The old version of golangci-lint doesn't work with go 1.18, so need to upgrade it as well. |
Signed-off-by: lyndon <[email protected]>
blackpiglet
approved these changes
Oct 19, 2022
reasonerjt
reviewed
Oct 19, 2022
reasonerjt
approved these changes
Oct 19, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade velero docker image to use go 1.18 and upgrade golangci-lint to 1.45.0