Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue of fail to get command output for test verification #5367

Conversation

danfengliu
Copy link
Contributor

@danfengliu danfengliu commented Sep 21, 2022

Signed-off-by: danfengl [email protected]

Thank you for contributing to Velero!

Please add a summary of your change

When running velero backup/restore command, if the command result is "PartiallyFailed", it won't reture error as design, but we do need to know the debug information to figure out the reason, so the command output is needed to get the command result, then further action will be taken.

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@danfengliu danfengliu added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Sep 21, 2022
When running velero backup/restore command, if the command result is "PartiallyFailed", it won't reture error as design, but we do need to know the debug information to figure out the reason, so the command output is needed to get the command result, then further action will be taken.

Signed-off-by: danfengl <[email protected]>
@danfengliu danfengliu force-pushed the fix-issue--command-return-message-checking branch from 070e039 to fdc2383 Compare September 21, 2022 02:52
@qiuming-best qiuming-best merged commit 100d462 into vmware-tanzu:main Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-e2e-tests kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants