Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 5352 #5356

Merged
merged 1 commit into from
Sep 19, 2022
Merged

Fix issue 5352 #5356

merged 1 commit into from
Sep 19, 2022

Conversation

Lyndon-Li
Copy link
Contributor

Fix issue 5352, fix the problem in UT TestGetVolumesRepositoryType which relies on fixed enumeration order of map

Signed-off-by: Lyndon-Li <[email protected]>
@Lyndon-Li Lyndon-Li added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Sep 19, 2022
@Lyndon-Li Lyndon-Li self-assigned this Sep 19, 2022
@Lyndon-Li Lyndon-Li requested review from blackpiglet and ywk253100 and removed request for dsu-igeek September 19, 2022 03:45
@codecov-commenter
Copy link

Codecov Report

Merging #5356 (dedb3e0) into main (1e138af) will decrease coverage by 0.21%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5356      +/-   ##
==========================================
- Coverage   40.82%   40.61%   -0.22%     
==========================================
  Files         234      234              
  Lines       20269    20293      +24     
==========================================
- Hits         8274     8241      -33     
- Misses      11393    11450      +57     
  Partials      602      602              
Impacted Files Coverage Δ
pkg/plugin/clientmgmt/manager.go 80.00% <0.00%> (-1.33%) ⬇️
pkg/restore/restore.go 64.72% <0.00%> (-0.14%) ⬇️
pkg/cmd/server/server.go 6.59% <0.00%> (ø)
pkg/cmd/cli/restic/server.go 12.50% <0.00%> (ø)
pkg/plugin/framework/server.go 0.00% <0.00%> (ø)
pkg/controller/backup_controller.go 48.06% <0.00%> (ø)
pkg/plugin/framework/object_store.go 0.00% <0.00%> (ø)
pkg/plugin/framework/plugin_lister.go 0.00% <0.00%> (ø)
internal/velero/serverstatusrequest.go 0.00% <0.00%> (ø)
pkg/controller/backup_sync_controller.go 42.56% <0.00%> (ø)
... and 48 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@blackpiglet blackpiglet merged commit 32b48d0 into vmware-tanzu:main Sep 19, 2022
@Lyndon-Li Lyndon-Li deleted the issue-fix-5352 branch September 19, 2022 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-unit-tests kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants