Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add schedule backup timing E2E test #5355

Merged

Conversation

danfengliu
Copy link
Contributor

@danfengliu danfengliu commented Sep 18, 2022

Signed-off-by: danfengl [email protected]

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #5033

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2022

Codecov Report

Merging #5355 (54aa90b) into main (100d6b4) will decrease coverage by 0.23%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5355      +/-   ##
==========================================
- Coverage   40.84%   40.61%   -0.24%     
==========================================
  Files         234      234              
  Lines       20260    20293      +33     
==========================================
- Hits         8276     8241      -35     
- Misses      11383    11450      +67     
- Partials      601      602       +1     
Impacted Files Coverage Δ
pkg/uploader/provider/restic.go 26.59% <0.00%> (-4.44%) ⬇️
pkg/plugin/clientmgmt/manager.go 80.00% <0.00%> (-1.33%) ⬇️
pkg/controller/pod_volume_backup_controller.go 39.15% <0.00%> (-0.42%) ⬇️
pkg/restore/restore.go 64.72% <0.00%> (-0.14%) ⬇️
pkg/cmd/server/server.go 6.59% <0.00%> (ø)
pkg/cmd/cli/restic/server.go 12.50% <0.00%> (ø)
pkg/plugin/framework/server.go 0.00% <0.00%> (ø)
pkg/controller/backup_controller.go 48.06% <0.00%> (ø)
pkg/plugin/framework/object_store.go 0.00% <0.00%> (ø)
pkg/plugin/framework/plugin_lister.go 0.00% <0.00%> (ø)
... and 50 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danfengliu danfengliu force-pushed the add-schedule-backup-timing-e2e-test branch 7 times, most recently from 4f9a50f to 8197019 Compare September 21, 2022 02:15
@danfengliu danfengliu force-pushed the add-schedule-backup-timing-e2e-test branch from 8197019 to 8043054 Compare September 21, 2022 02:32
@danfengliu danfengliu added this to the 1.10 milestone Sep 22, 2022
@qiuming-best qiuming-best merged commit 66f6365 into vmware-tanzu:main Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add E2E test to verify the immediate backup after schedule backup creation
4 participants